← Back to issue list

fix: use correct type for `build-on` and `build-for` in build plans

View original Github issue

Metadata

Project
snapcraft
Number
#5043
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged a fix correcting the type usage for build-on and build-for in build plans. Added unit and spread tests. Passed CI and received two reviewer approvals before merge.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- * Fixes an issue where the wrong type was used when creating a build plan. * Adds a unit test and spread test for a failure described in https://forum.snapcraft.io/t/building-snaps/41982

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix correcting the type usage for build-on and build-for in build plans. Added unit and spread tests. Passed CI and received two reviewer approvals before merge.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for incorrect type usage in build-on and build-for build plans. Added unit and spread tests. The author confirmed a test failure was an unrelated network error, and the changes were successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Merged correction for incorrect types in build-on and build-for build plan fields. Includes unit and spread tests to prevent regression. Author dismissed an unrelated Core20 network test failure.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.