← Back to issue list

fix: use correct type for `build-on` and `build-for` in build plans

View original Github issue

Metadata

Project
snapcraft
Number
#5043
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5043 (commit 19699c1b8) corrected build-on/build-for types in build plans and added unit and spread regression tests.

Resolution: closed resolved

Reason: PR #5043 was merged into snapcraft as commit 19699c1b8, fixing the incorrect build plan types and adding regression coverage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- * Fixes an issue where the wrong type was used when creating a build plan. * Adds a unit test and spread test for a failure described in https://forum.snapcraft.io/t/building-snaps/41982

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5043 (commit 19699c1b8) corrected build-on/build-for types in build plans and added unit and spread regression tests.
stealth/space-bunny-alpha — closed resolved Merged PR #5043 (commit 19699c1b8) fixed incorrect types for build-on and build-for in build plans, with unit and spread regression tests.
qwen/qwen3.6-35b-a3b — — Merged a fix correcting the type usage for build-on and build-for in build plans. Added unit and spread tests. Passed CI and received two reviewer approvals before merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for incorrect type usage in build-on and build-for build plans. Added unit and spread tests. The author confirmed a test failure was an unrelated network error, and the changes were successfully integrated.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.