← Back to issue list

build(deps): bump craft-grammar to 2.0.1

View original Github issue

Metadata

Project
snapcraft
Number
#5051
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5051 (commit 0e2cfbf56) bumped craft-grammar to 2.0.1 and craft-store to 3.0.1, fixing numeric-to-string model coercion and closing #4978 and #5017. Approved by 2 reviewers.

Resolution: closed resolved

Reason: The PR itself was merged into snapcraft as commit 0e2cfbf56 ("build(deps): bump craft-grammar to 2.0.1"), upgrading craft-grammar from 1.2.0 to 2.0.1. That release fixes model coercion of numbers to strings, which resolved snapcraft#4978 and snapcraft#5017, both now closed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- ## craft-store ### 3.0.1 (2024-09-20) - Fix a regression where Ubuntu One macaroons could not be refreshed - Make craft-store compatible with keyring v25 ## craft-grammar ### 2.0.1 (2024-08-18) - Fix cases where models were not correctly coercing numbers to strings. Fixes #4978 Fixes #5017

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5051 (commit 0e2cfbf56) bumped craft-grammar to 2.0.1 and craft-store to 3.0.1, fixing numeric-to-string model coercion and closing #4978 and #5017. Approved by 2 reviewers.
stealth/space-bunny-alpha — closed resolved Merged PR #5051 (commit 0e2cfbf56) bumped craft-grammar to 2.0.1 and craft-store to 3.0.1, restoring numeric-to-string model coercion and fixing issues #4978 and #5017.
stealth/space-bunny-alpha — closed resolved Merged PR #5051 bumped craft-grammar to 2.0.1 (restoring numeric-to-string model coercion) and craft-store to 3.0.1, fixing #4978 and #5017. Reviewer asked to include craft-store; author folded it in.
stealth/space-bunny-alpha — closed resolved Merged PR #5051 bumped craft-grammar to 2.0.1, fixing numeric-to-string model coercion and resolving #4978 and #5017; it also included craft-store 3.0.1.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI checks. Bumped craft-grammar to 2.0.1 to fix model number coercion issues (#4978, #5017). Included craft-store 3.0.1 and craft-application updates per reviewer request to consolidate dependency bumps.
qwen3.6-35b-a3b-mtp-q6 — — Merged dependency updates bumping craft-grammar to 2.0.1 and craft-store to 3.0.1. Combined multiple version bumps into a single PR per reviewer feedback, resolving issues #4978 and #5017.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#4978 (confidence 97%)

    Stricter edge-channel build-environment type handling; closed by this grammar upgrade restoring int-to-string coercion.

  • Likely Fixed By: snapcraft#5017 (confidence 97%)

    Unexpectedly strict linting after the Pydantic 2 migration; same coercion fix in craft-grammar 2.0.1.

Related issues

Issue Project State Summary Similarity
#202 build(deps): update internal packages imagecraft merged Merged as commit 3282dc5, updating craft-grammar 2.1.0→2.2.0 and craft-parts 2.20.0→2.21.0 with all CI checks passing.
78%
#200 build(deps): update dependency craft-grammar to ~=2.1.0 imagecraft merged Merged the craft-grammar upgrade from ~=2.0.3 to ~=2.1.0 in canonical/imagecraft#200 (commit addb058). A retry refreshed the lockfile; all CI checks passed.
76%
#5084 build(deps): bump craft-store to 3.0.2 snapcraft merged Merged as 1b5789fa8: upgraded craft-store to 3.0.2 and cherry-picked #5061, fixing #5077's core20 build failures; released in Snapcraft 8.4.2.
76%
#1250 build(deps): bump craft-parts to 2.34.0 rockcraft closed PR #1250 was closed unmerged after four CI checks failed; later commit ab4f617f updated craft-parts to 2.35.0 instead.
74%
#42 release: 2.0.0 (CRAFT-772) craft-store merged Merged #42 to release craft-store 2.0.0 for CRAFT-772; release commit 1b34846 and merge commit cb6ccd9 finalized the two-file version bump.
73%
#18 Release 1.2.0 craft-grammar merged Merged release PR #18 delivered craft-grammar 1.2.0 with changelog updates, additional grammar types, typing improvements, and a version bump in commit a1317b9.
73%
#4731 chore(deps): update dependency craft-grammar to v1.2.0 snapcraft merged Renovate dependency bump of craft-grammar from 1.1.1/1.1.2 to 1.2.0 was approved and merged via commit be36b4dc0, updating 3 files (+3/-3).
73%
#48 release: 2.0.1 craft-store merged Merged craft-store 2.0.1 via PR #48; merge commit fb75d74 brought in release commit 53f880d.
73%
#1388 build(deps): bump craft-store to 2.5.0 charmcraft merged Merged PR #1388 as commit 70066d49, upgrading craft-store to 2.5.0 to add a file-based keyring fallback on headless systems and fix #719.
73%
#4787 build(deps): bump craft-store to 2.6.2 snapcraft merged Merged #4787 as fcbccf9ab, bumping craft-store to 2.6.2 so cryptography imports work on Focal without OpenSSL legacy providers.
73%