← Back to issue list

Move examples to demos

View original Github issue

Metadata

Project
snapcraft
Number
#506
Type
pull request
State
closed
Author
didrocks
Labels
—
Created
Updated
Closed

Current evaluation

PR to rename examples to demos was closed by kyrofa in favor of #522, which re-did the change and was merged as commit e58d857ee; #513 added the new scaffolded examples.

Resolution: closed superseded

Reason: The PR was never merged as-is: kyrofa closed it in favor of PR #522 ("Move examples to demos"), which was merged and landed as commit e58d857ee. Related PR #513 (merged as 7f334a5b1) depended on it to add the scaffolded getting-started examples.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Rename current examples as demos as it's more what they are about. Ensure that CI still runs when growing a new "demos" argument and keep examples backward compatibility until we introduce real examples as getting started guide. For now, we keep the snapcraft-examples package. I think this package can ship both demos and examples. This is the base work for the new "snapcraft-examples" command which will scaffold the getting started examples we work together on. I feel we may have to push this command (and so examples) as part of the main package though (and so, can introduce confusion with the existing package name). Note that I kept backward compatibility for CI. I couldn't run the whole CI testsuite though as it requires some 15.04 snappy/u-d-f and will rely on the current automated CI test results then :)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR to rename examples to demos was closed by kyrofa in favor of #522, which re-did the change and was merged as commit e58d857ee; #513 added the new scaffolded examples.
stealth/space-bunny-alpha — closed superseded Replaced by canonical/snapcraft#522, which merged the examples-to-demos rename and CI compatibility updates in commit e58d857ee.
qwen/qwen3.6-35b-a3b — — Closed and superseded by pull request #522. The proposed rename of examples to demos and CI compatibility adjustments were redirected to the newer PR instead of merging here.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #522. The changes to rename examples to demos and maintain CI compatibility were closed in favor of a follow-up pull request after review and conflict resolution.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#522 (confidence 99%)

    Closing comment from kyrofa: "Closing in favor of #522"; #522 merged as commit e58d857ee with the same title.

  • Related To: canonical/snapcraft#513 (confidence 90%)

    PR noted as depending on this one to scaffold getting-started examples; merged as commit 7f334a5b1.

Related issues

Issue Project State Summary Similarity
#522 Move examples to demos snapcraft merged Merged PR #522 moved Snapcraft examples to demos, superseding #506; the change landed as commit e58d857ee.
79%