← Back to issue list

fix: correctly set PIP_NO_BINARY

View original Github issue

Metadata

Project
snapcraft
Number
#5061
Type
pull request
State
closed
Author
dariuszd21
Labels
—
Created
Updated
Closed

Current evaluation

PR setting PIP_NO_BINARY correctly (was parsed as a package name by pip) was not merged directly; it was cherry-picked into snapcraft#5084 (bump craft-store to 3.0.2, commit 1b5789fa8), fixing #5077 and shipping in Snapcraft 8.4.2.

Resolution: closed resolved

Reason: Maintainer mr-cal closed the PR on 2024-10-04 stating the change was cherry-picked into snapcraft#5084, which merged as commit 1b5789fa8 upgrading craft-store to 3.0.2 (the underlying craft-store change being canonical/craft-store#221). The fix released in Snapcraft 8.4.2 and resolved #5077.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR setting PIP_NO_BINARY correctly (was parsed as a package name by pip) was not merged directly; it was cherry-picked into snapcraft#5084 (bump craft-store to 3.0.2, commit 1b5789fa8), fixing #5077 and shipping in Snapcraft 8.4.2.
stealth/space-bunny-alpha — closed superseded PIP_NO_BINARY fix was closed after its change was cherry-picked into merged #5084 (1b5789fa8), upgrading craft-store to 3.0.2; the fix shipped in Snapcraft 8.4.2.
stealth/space-bunny-alpha — closed superseded Closed unmerged after the PIP_NO_BINARY fix was cherry-picked into #5084, which merged as 1b5789fa8 and upgraded craft-store to 3.0.2.
stealth/space-bunny-alpha — closed superseded PIP_NO_BINARY fix was cherry-picked into #5084, merged as 1b5789fa8 and shipped with craft-store 3.0.2; original #5061 was closed unmerged.
stealth/space-bunny-alpha — closed resolved PIP_NO_BINARY fix was cherry-picked into merged canonical/snapcraft#5084 (1b5789fa8); this PR was then closed.
stealth/space-bunny-alpha — closed superseded Closed unmerged; the PIP_NO_BINARY fix was cherry-picked into merged PR canonical/snapcraft#5084 (1b5789fa8).
qwen/qwen3.6-35b-a3b — — The PIP_NO_BINARY fix was closed and superseded after its changes were cherry-picked into pull request #5084.
qwen3.6-35b-a3b-mtp-q6 — — Closed and cherry-picked into pull request 5084. Correctly sets PIP_NO_BINARY to handle pip :all handling, resolving build time issues and potentially fixing RISC-V builds.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#5084 (confidence 95%)

    Cherry-pick target that merged the PIP_NO_BINARY fix via craft-store 3.0.2 bump (commit 1b5789fa8)

  • Related To: snapcraft#5077 (confidence 85%)

    Broken core20 armhf builds that #5084 fixed via this cherry-picked change

  • Likely Fixed By: canonical/craft-store#221 (confidence 70%)

    Upstream craft-store PR cited by maintainer as the underlying dependency change making this pass

Related issues

No related issues found above the similarity threshold.