← Back to issue list

build(deps): update dependency requests to v2.32.2 [security] (hotfix/7.5)

View original Github issue

Metadata

Project
snapcraft
Number
#5065
Type
pull request
State
merged
Author
renovate[bot]
Labels
—
Created
Updated
Closed

Current evaluation

Merged into hotfix/7.5 as 4df808913, updating requests from 2.28.1 to 2.32.2 to remediate CVE-2024-35195.

Resolution: closed resolved

Reason: PR #5065 was merged into hotfix/7.5 as commit 4df808913. Its dependency change upgrades requests to 2.32.2, addressing CVE-2024-35195.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [requests](https://requests.readthedocs.io) ([source](https://redirect.github.com/psf/requests), [changelog](https://redirect.github.com/psf/requests/blob/master/HISTORY.md)) | `==2.28.1` -> `==2.32.2` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/requests/2.32.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/requests/2.32.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/requests/2.28.1/2.32.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/requests/2.28.1/2.32.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2024-35195](https://redirect.github.com/psf/requests/security/advisories/GHSA-9wx4-h78v-vm56) When making requests through a Requests `Session`, if the first request is made with `verify=False` to disable cert verification, all subsequent requests to the same origin will continue to ignore cert verification regardless of changes to the value of `verify`. This behavior will continue for the lifecycle of the connection in the connection pool. ### Remediation Any of these options can be used to remediate the current issue, we highly recommend upgrading as the preferred mitigation. * Upgrade to `requests>=2.32.0`. * For `requests<2.32.0`, avoid setting `verify=False` for the first request to a host while using a Requests Session. * For `requests<2.32.0`, call `close()` on `Session` objects to clear existing connections if `verify=False` is used. ### Related Links * [https://github.com/psf/requests/pull/6655](https://redirect.github.com/psf/requests/pull/6655) --- ### Release Notes <details> <summary>psf/requests (requests)</summary> ### [`v2.32.2`](https://redirect.github.com/psf/requests/blob/HEAD/HISTORY.md#2322-2024-05-21) [Compare Source](https://redirect.github.com/psf/requests/compare/v2.32.1...v2.32.2) **Deprecations** - To provide a more stable migration for custom HTTPAdapters impacted by the CVE changes in 2.32.0, we've renamed `_get_connection` to a new public API, `get_connection_with_tls_context`. Existing custom HTTPAdapters will need to migrate their code to use this new API. `get_connection` is considered deprecated in all versions of Requests>=2.32.0. A minimal (2-line) example has been provided in the linked PR to ease migration, but we strongly urge users to evaluate if their custom adapter is subject to the same issue described in CVE-2024-35195. ([#&#8203;6710](https://redirect.github.com/psf/requests/issues/6710)) ### [`v2.32.1`](https://redirect.github.com/psf/requests/blob/HEAD/HISTORY.md#2321-2024-05-20) [Compare Source](https://redirect.github.com/psf/requests/compare/v2.32.0...v2.32.1) **Bugfixes** - Add missing test certs to the sdist distributed on PyPI. ### [`v2.32.0`](https://redirect.github.com/psf/requests/blob/HEAD/HISTORY.md#2320-2024-05-20) [Compare Source](https://redirect.github.com/psf/requests/compare/v2.31.0...v2.32.0) **Security** - Fixed an issue where setting `verify=False` on the first request from a Session will cause subsequent requests to the *same origin* to also ignore cert verification, regardless of the value of `verify`. (https://github.com/psf/requests/security/advisories/GHSA-9wx4-h78v-vm56) **Improvements** - `verify=True` now reuses a global SSLContext which should improve request time variance between first and subsequent requests. It should also minimize certificate load time on Windows systems when using a Python version built with OpenSSL 3.x. ([#&#8203;6667](https://redirect.github.com/psf/requests/issues/6667)) - Requests now supports optional use of character detection (`chardet` or `charset_normalizer`) when repackaged or vendored. This enables `pip` and other projects to minimize their vendoring surface area. The `Response.text()` and `apparent_encoding` APIs will default to `utf-8` if neither library is present. ([#&#8203;6702](https://redirect.github.com/psf/requests/issues/6702)) **Bugfixes** - Fixed bug in length detection where emoji length was incorrectly calculated in the request content-length. ([#&#8203;6589](https://redirect.github.com/psf/requests/issues/6589)) - Fixed deserialization bug in JSONDecodeError. ([#&#8203;6629](https://redirect.github.com/psf/requests/issues/6629)) - Fixed bug where an extra leading `/` (path separator) could lead urllib3 to unnecessarily reparse the request URI. ([#&#8203;6644](https://redirect.github.com/psf/requests/issues/6644)) **Deprecations** - Requests has officially added support for CPython 3.12 ([#&#8203;6503](https://redirect.github.com/psf/requests/issues/6503)) - Requests has officially added support for PyPy 3.9 and 3.10 ([#&#8203;6641](https://redirect.github.com/psf/requests/issues/6641)) - Requests has officially dropped support for CPython 3.7 ([#&#8203;6642](https://redirect.github.com/psf/requests/issues/6642)) - Requests has officially dropped support for PyPy 3.7 and 3.8 ([#&#8203;6641](https://redirect.github.com/psf/requests/issues/6641)) **Documentation** - Various typo fixes and doc improvements. **Packaging** - Requests has started adopting some modern packaging practices. The source files for the projects (formerly `requests`) is now located in `src/requests` in the Requests sdist. ([#&#8203;6506](https://redirect.github.com/psf/requests/issues/6506)) - Starting in Requests 2.33.0, Requests will migrate to a PEP 517 build system using `hatchling`. This should not impact the average user, but extremely old versions of packaging utilities may have issues with the new packaging format. ### [`v2.31.0`](https://redirect.github.com/psf/requests/blob/HEAD/HISTORY.md#2310-2023-05-22) [Compare Source](https://redirect.github.com/psf/requests/compare/v2.30.0...v2.31.0) **Security** - Versions of Requests between v2.3.0 and v2.30.0 are vulnerable to potential forwarding of `Proxy-Authorization` headers to destination servers when following HTTPS redirects. When proxies are defined with user info (`https://user:pass@proxy:8080`), Requests will construct a `Proxy-Authorization` header that is attached to the request to authenticate with the proxy. In cases where Requests receives a redirect response, it previously reattached the `Proxy-Authorization` header incorrectly, resulting in the value being sent through the tunneled connection to the destination server. Users who rely on defining their proxy credentials in the URL are *strongly* encouraged to upgrade to Requests 2.31.0+ to prevent unintentional leakage and rotate their proxy credentials once the change has been fully deployed. Users who do not use a proxy or do not supply their proxy credentials through the user information portion of their proxy URL are not subject to this vulnerability. Full details can be read in our [Github Security Advisory](https://redirect.github.com/psf/requests/security/advisories/GHSA-j8r2-6x86-q33q) and [CVE-2023-32681](https://nvd.nist.gov/vuln/detail/CVE-2023-32681). ### [`v2.30.0`](https://redirect.github.com/psf/requests/blob/HEAD/HISTORY.md#2300-2023-05-03) [Compare Source](https://redirect.github.com/psf/requests/compare/v2.29.0...v2.30.0) **Dependencies** - ⚠️ Added support for urllib3 2.0. ⚠️ This may contain minor breaking changes so we advise careful testing and reviewing https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html prior to upgrading. Users who wish to stay on urllib3 1.x can pin to `urllib3<2`. ### [`v2.29.0`](https://redirect.github.com/psf/requests/blob/HEAD/HISTORY.md#2290-2023-04-26) [Compare Source](https://redirect.github.com/psf/requests/compare/v2.28.2...v2.29.0) **Improvements** - Requests now defers chunked requests to the urllib3 implementation to improve standardization. ([#&#8203;6226](https://redirect.github.com/psf/requests/issues/6226)) - Requests relaxes header component requirements to support bytes/str subclasses. ([#&#8203;6356](https://redirect.github.com/psf/requests/issues/6356)) ### [`v2.28.2`](https://redirect.github.com/psf/requests/blob/HEAD/HISTORY.md#2282-2023-01-12) [Compare Source](https://redirect.github.com/psf/requests/compare/v2.28.1...v2.28.2) **Dependencies** - Requests now supports charset_normalizer 3.x. ([#&#8203;6261](https://redirect.github.com/psf/requests/issues/6261)) **Bugfixes** - Updated MissingSchema exception to suggest https scheme rather than http. ([#&#8203;6188](https://redirect.github.com/psf/requests/issues/6188)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/canonical/snapcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45NC4zIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6ImhvdGZpeC83LjUiLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.5 as 4df808913, updating requests from 2.28.1 to 2.32.2 to remediate CVE-2024-35195.
stealth/space-bunny-alpha — closed resolved Renovate PR #5065 merged into hotfix/7.5 as commit 4df808913, bumping requests from 2.28.1 to 2.32.2 to remediate CVE-2024-35195 (GHSA-9wx4-h78v-vm56). Same bump merged on main (#5064, ec4f9b16f) and hotfix/8.4 (#5067).
stealth/space-bunny-alpha — closed resolved Merged #5065 into hotfix/7.5 as commit 4df808913, upgrading requests from 2.28.1 to 2.32.2 to remediate CVE-2024-35195.
qwen/qwen3.6-35b-a3b — — Merged an automated security update upgrading the requests dependency from v2.28.1 to v2.32.2 to fix CVE-2024-35195. Approved by two reviewers, passed CI, and merged into the hotfix/7.5 branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged automated update upgrading requests from v2.28.1 to v2.32.2 on the hotfix/7.5 branch to resolve CVE-2024-35195, fixing an SSL certificate verification bypass vulnerability in Sessions.

Update history

No update history recorded yet.

Related work

  • Related To: requests#6655 (confidence 100%)

    Upstream Requests change referenced by the PR for the certificate-verification security fix.

  • Related To: canonical/snapcraft#5067 (confidence 98%)

    Parallel merged hotfix updating requests to 2.32.2 for the same CVE on hotfix/8.4.

Related issues

Issue Project State Summary Similarity
#5066 build(deps): update dependency requests to v2.32.2 [security] (hotfix/8.3) snapcraft closed Renovate security bump of requests 2.31.0->2.32.2 for hotfix/8.3 (CVE-2024-35195) was closed unmerged after ~724 days of inactivity; same update merged for main (#5064), hotfix/7.5 (#5065) and hotfix/8.4 (#5067).
90%
#5551 build(deps): update dependency requests to v2.32.4 [security] (hotfix/8.9) snapcraft merged Merged in fc81a5369, upgrading requests from 2.32.3 to 2.32.4 on hotfix/8.9 to address CVE-2024-47081 credential leakage.
88%
#5550 build(deps): update dependency requests to v2.32.4 [security] (hotfix/7.5) - autoclosed snapcraft closed Autoclosed unmerged; the requests 2.32.4 security update landed on hotfix/8.9 via merged #5551 (fc81a5369), not hotfix/7.5.
88%
#5067 build(deps): update dependency requests to v2.32.2 [security] (hotfix/8.4) snapcraft merged Renovate's requests 2.31.0 -> 2.32.2 security bump for CVE-2024-35195 was merged into hotfix/8.4 as commit 8a0a3dc62, one line changed in the requirements file.
87%
#5064 build(deps): update dependency requests to v2.32.2 [security] (main) snapcraft merged Merged PR #5064 as ec4f9b16f, updating requests from 2.31.0 to 2.32.2 to remediate CVE-2024-35195.
86%
#1516 build(deps): update dependency requests to v2.33.0 [security] (main) craft-parts merged Merged PR #1516 as commit 3d099307, upgrading requests from 2.32.5 to 2.33.0 to remediate CVE-2026-25645.
84%
#5549 build(deps): update dependency requests to v2.32.4 [security] (main) snapcraft closed Renovate PR to bump requests 2.32.3 -> 2.32.4 (CVE-2024-47081) on main was closed unmerged; the fix shipped via hotfix PR #5551 (fc81a5369) and reached main in #5557 (3a614faa3).
84%
#1519 build(deps): update dependency requests to v2.33.0 [security] (hotfix/2.7) craft-parts closed Closed unmerged after failing checks; the equivalent requests 2.33.0 security update was merged into main by #1516 at commit 3d099307.
84%
#1518 build(deps): update dependency requests to v2.33.0 [security] (hotfix/2.28) - autoclosed craft-parts closed Renovate autoclosed #1518 unmerged; the equivalent requests 2.33.0 security update merged to main via #1516 (3d099307). No 2.28 hotfix backport was recorded.
83%
#1921 build(deps): update dependency requests to v2.32.2 [security] (hotfix/2.7) - autoclosed charmcraft closed Renovate PR #1921 proposed requests 2.32.2 for hotfix/2.7 but was autoclosed unmerged after receiving no review or CI.
83%