fix(remotebuild): do not auto clean interrupted builds
Metadata
Current evaluation
Merged fix preventing the remote builder from auto-cleaning interrupted builds. Replaced magic values with constants and resolved issue #4929. Approved by reviewers and passed CI checks.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Fixes a bug where the remote builder would ignore the user and always clean the launchpad project.
Also drops some magic values in favor of constants.
(CRAFT-3140)
Fixes #4929
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix preventing the remote builder from auto-cleaning interrupted builds. Replaced magic values with constants and resolved issue #4929. Approved by reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix preventing the remote builder from automatically cleaning interrupted builds, respecting user configuration. Replaced magic values with constants. Resolves #4929 and CRAFT-3140. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix preventing the remote builder from automatically cleaning interrupted Launchpad builds. Replaced magic values with constants. Resolves #4929 and CRAFT-3140. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #625 fix(remote-build): don't cleanup after a timeout | craft-application | merged | Merged fix preventing remote builder cleanup after timeouts and removing references to a non-existent --build-id option. Approved by two reviewers, passed CI, and rebased to main for release 4.8.3. Resolves #618 and #619. | |
| #4432 fix(remote-build): improve logging and catch exceptions | snapcraft | merged | Merged pull request improving remote build logging and exception handling. Approved by reviewers, passed CI checks, and resolves issue #4399. | |
| #2642 remote-build: detect early build errors | snapcraft | merged | Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied. | |
| #4480 fix(remote): return error when remote build failed | snapcraft | merged | Successfully merged fix for remote build failures that returns proper errors, resolving issue #4142. Approved by three reviewers with maintained code coverage across 13 files. | |
| #4826 fix(remote-build): fail if no artifacts are created | snapcraft | merged | Merged fix for issue #4783 that ensures remote builds fail when no artifacts are generated. Approved by two reviewers, passed CI, and merged with 214 additions and 4 deletions across two files. | |
| #310 fix(remote-build): enable git repo check | craft-application | merged | Successfully merged the fix enabling the git repository check for remote builds. Approved by two reviewers, the update modifies two files with 18 additions and 1 deletion, resolving the build configuration issue. |