← Back to issue list

fix(remotebuild): do not auto clean interrupted builds

View original Github issue

Metadata

Project
snapcraft
Number
#5081
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5081 (commit caa0757c2) fixes remote-build cleanup after interruption, respecting the user's choice and resolving #4929.

Resolution: closed resolved

Reason: PR #5081 was approved and merged as commit caa0757c2, fixing the behavior reported in issue #4929.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Fixes a bug where the remote builder would ignore the user and always clean the launchpad project. Also drops some magic values in favor of constants. (CRAFT-3140) Fixes #4929

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5081 (commit caa0757c2) fixes remote-build cleanup after interruption, respecting the user's choice and resolving #4929.
stealth/space-bunny-alpha — closed resolved Merged in #5081 (commit caa0757c2): remote-build no longer automatically cleans the Launchpad project after interrupted builds and respects the user's choice.
stealth/space-bunny-alpha — closed resolved Merged PR #5081 (commit caa0757c2) fixed remote-build cancellation respecting user choice instead of always cleaning the Launchpad project; issue #4929 was resolved.
qwen/qwen3.6-35b-a3b — — Merged fix preventing the remote builder from auto-cleaning interrupted builds. Replaced magic values with constants and resolved issue #4929. Approved by reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix preventing the remote builder from automatically cleaning interrupted builds, respecting user configuration. Replaced magic values with constants. Resolves #4929 and CRAFT-3140.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#4929 (confidence 100%)

    This PR directly fixes the cancellation and automatic-cleanup bug reported in issue #4929.

Related issues

No related issues found above the similarity threshold.