Honor the ${pcfiledir} entries in pkgconfig
Metadata
Current evaluation
Merged in commit 0a7f753ac, preserving prefix= in relocatable pkg-config files that use ${pcfiledir}; fixes #5158.
Resolution: closed resolved
Reason: PR #5157 was approved and merged as commit 0a7f753ac. It stops rewriting prefix= when ${pcfiledir} makes .pc files relocatable, resolving #5158.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The ${pcfiledir} tag allows to make .pc files relocatables, by being replaced with the path where the .pc file is stored. In these cases, the "prefix=" entry must be left as-is, to ensure that it continues to work as expected.
It is complemented by https://github.com/canonical/craft-parts/pull/977
Fix #5158
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 0a7f753ac, preserving prefix= in relocatable pkg-config files that use ${pcfiledir}; fixes #5158. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #5157 as 0a7f753ac to honor ${pcfiledir} in relocatable pkg-config files, backed by craft-parts 2.4.1; fixes #5158. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 0a7f753ac (#5157), preserving ${pcfiledir} in relocatable pkg-config files and requiring craft-parts 2.4.1; craft-parts#977 provides the Core24+ fix. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #5157 as 0a7f753ac, preserving ${pcfiledir} and leaving prefix unchanged for relocatable pkg-config files; craft-parts#977 provides the complementary fix. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following two approvals and passing CI. The change updates the craft-parts dependency and implements logic to honor ${pcfiledir} entries in pkgconfig, ensuring .pc files remain relocatable. Resolves #5158. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to honor ${pcfiledir} entries in pkgconfig files, ensuring relocatability. Updated the craft-parts dependency to version 2.4.1, passed coverage checks, and resolved issue #5158. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#5158
(confidence 100%)
The reported pkg-config bug was fixed by this merged PR.
-
Related To:
canonical/craft-parts#977
(confidence 100%)
Complementary ${pcfiledir} support for Core24+.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #977 fix: Honor the ${pcfiledir} entries in pkgconfig | craft-parts | merged | Merged as b4a09d95, preserving ${pcfiledir}-based prefixes so relocatable pkg-config files remain valid; released in Craft Parts 2.4.1. |