← Back to issue list

feat: validate build commands before execution

View original Github issue

Metadata

Project
snapcraft
Number
#5164
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged #5164 (CRAFT-3293), adding pre-execution validation for app build-command definitions and closing #4999; the validation shipped in Snapcraft 8.5.1.

Resolution: closed resolved

Reason: Pull request #5164 was approved and merged, explicitly stating that it closes #4999. Snapcraft 8.5.1 credits #4999 for the requested command-field validation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Closes #4999. (CRAFT-3293)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #5164 (CRAFT-3293), adding pre-execution validation for app build-command definitions and closing #4999; the validation shipped in Snapcraft 8.5.1.
stealth/space-bunny-alpha — closed resolved Merged build-command validation to close snapcraft#4999, adding pre-execution checks for app command definitions (CRAFT-3293).
qwen/qwen3.6-35b-a3b — — Merged feature validating build commands before execution, closing #4999. Approved by two reviewers with passing CI checks. Changelog entry added for release tracking.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds validation for build commands before execution, closing issue #4999. A changelog entry was added per maintainer request. Resolves CRAFT-3293.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#4721 feat: validate devel bases with craft-application snapcraft closed Superseded by canonical/snapcraft#4796, merged as commit 5dad5eb62, which upgraded craft-application to 2.7.0 and adopted its devel-base validation.
73%
#813 "snapcraft validate" and "snapcraft gated" commands snapcraft merged Merged PR #813 in commit 2d429cf12, adding commands to inspect gated snaps and submit validation assertions.
72%