← Back to issue list

chore: add a CODEOWNERS file

View original Github issue

Metadata

Project
snapcraft
Number
#5177
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #5177 (fc8cfbb26), adding CODEOWNERS; proposed team additions were dropped because CODEOWNERS entries require repository write access.

Resolution: closed resolved

Reason: PR #5177 was approved and merged as commit fc8cfbb26, adding the initial CODEOWNERS file. The closing discussion confirmed that broader team entries were intentionally omitted because owners must have repository write access.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This file follows the standard Starcraft ownership model, but there might be more nuances for snapcraft. For example, should there be additional owners on things like the gnome extension? - [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #5177 (fc8cfbb26), adding CODEOWNERS; proposed team additions were dropped because CODEOWNERS entries require repository write access.
stealth/space-bunny-alpha — closed resolved Merged in #5177 (fc8cfbb26), adding the initial CODEOWNERS file. Proposed team additions were rejected because CODEOWNERS entries require repository write access.
qwen/qwen3.6-35b-a3b — — Merged the initial CODEOWNERS file, but rejected requests to add specific teams. Maintainers withdrew the additions because CODEOWNERS requires repository write access, which they declined to grant.
qwen3.6-35b-a3b-mtp-q6 — — Merged the CODEOWNERS file but reverted requested team additions. Maintainers declined to add groups as codeowners due to repository write access security concerns.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#142 chore: add a CODEOWNERS file craft-archives closed Closed unmerged; the CODEOWNERS proposal was later implemented by merged PR #226 in commit c566fce.
92%
#121 chore: add a CODEOWNERS file imagecraft closed Closed unmerged after deciding not to adopt CODEOWNERS; the proposed file was later added by #295 in commit 913e475.
92%
#589 chore: add a CODEOWNERS file craft-application closed Closed unmerged after maintainers decided not to adopt the proposed 19-line CODEOWNERS file.
88%
#2035 chore: add CODEOWNERS file charmcraft merged Merged PR #2035 (commit af590552) by maintainer lengau after 2 approvals, adding a 12-line .github/CODEOWNERS file setting @lengau as global owner plus docs/templates ownership rules.
87%
#747 chore: add CODEOWNERS craft-providers merged PR #747 was merged into main via commit e68ff2c, adding .github/CODEOWNERS to define global, documentation, and ownership-rule review responsibilities.
86%
#83 chore: add a CODEOWNERS file craft-platforms merged PR #83 merged as commit 1da9c16, adding .github/CODEOWNERS (+20 lines) to define global, docs, per-module (charm/rock/snap) and starcraft-maintainer review ownership; approved by 2 reviewers.
86%
#768 chore: add a CODEOWNERS file rockcraft closed Merged canonical/rockcraft#768 into main, adding CODEOWNERS to automate review assignments.
86%
#1095 chore: add CODEOWNERS craft-parts merged Merged PR #1095 in commit 4359cf3f, adding .github/CODEOWNERS to formalize craft-parts maintainer ownership for the cycle.
85%
#837 chore: update CODEOWNERS craft-providers merged Merged PR #837 updated project CODEOWNERS assignments; the change landed as commit a0967cc.
83%
#2647 chore: update `CODEOWNERS` charmcraft merged Merged into main as fa075d8c, updating .github/CODEOWNERS with four ownership-line changes.
82%