← Back to issue list

fix: properly present help when posargs have no help

View original Github issue

Metadata

Project
snapcraft
Number
#5178
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged fix for help display when positional arguments lack descriptions. Approved by two reviewers, passed CI, and applied with minimal changes across four files.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for help display when positional arguments lack descriptions. Approved by two reviewers, passed CI, and applied with minimal changes across four files.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that properly displays help for positional arguments without help text. The change was approved by a reviewer following a brief discussion on a related side-effect.
qwen3.6-35b-a3b-mtp-q6 Merged a fix ensuring help text displays correctly when positional arguments lack descriptions. Review acknowledged a side-effect but approved the change, resolving the issue.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#309 fix: hide positional arguments with no help craft-cli merged Merged, resolving issue #308. The change hides positional arguments without help text while preserving them in command syntax. Approved by two reviewers, passed CI checks, and updated three files (+102/-11 lines).
80%
#271 feat: display positional args in help craft-cli merged Merged to display positional arguments in help output. Approved by two reviewers, passed checks, and modified three files with 38 additions and 3 deletions.
78%
#207 Avoid a duplicated -h/--help option when getting help for a command. charmcraft merged Merged a fix to eliminate duplicate -h/--help options in command help output by disabling ArgumentParser's automatic help flag addition. Existing tests were updated to expose duplicates. Approved by two reviewers and passed CI.
72%
#95 fix: better help for invalid command args craft-application merged Merged into main after approval and CI checks. Resolves #89 by replacing the internal error for invalid command arguments with the standard help message, matching dispatcher behavior. Changes span 3 files with 100% diff coverage.
71%
#153 Adjust help messages in all cases to UX indications charmcraft merged Merged changes adding a dedicated help command, disabling automatic ArgumentParser help handling, and improving usage and error messages. Tests moved to test_help.py. Approved by two reviewers with 382 additions and 175 deletions across three files.
71%