← Back to issue list

Move the login and logout methods to a client.

View original Github issue

Metadata

Project
snapcraft
Number
#518
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #518 in commit 927936b87, relocating login and logout methods to a client object as the first split of the macaroons branch.

Resolution: closed resolved

Reason: The pull request was merged as commit 927936b87. Maintainer comments identify PR #511 as a prerequisite and discuss resolving cyclic dependency test failures before merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #518 in commit 927936b87, relocating login and logout methods to a client object as the first split of the macaroons branch.
stealth/space-bunny-alpha — closed resolved Login/logout were moved to a client object in merged PR #518 via commit 927936b87, delivering the same refactor after the dependency-related CI troubleshooting.
qwen/qwen3.6-35b-a3b — — Merged the initial macaroons branch split by moving login and logout methods to a client object. Resolved Travis CI failures caused by Python 3.4 cyclic dependencies and completed the merge following maintainer approval.
qwen3.6-35b-a3b-mtp-q6 — — Merged the initial macaroons branch split, relocating login and logout methods to a client object. Resolved Travis CI failures stemming from Python 3.4 cyclic dependencies and incorporated reviewer feedback. Depends on PR #511.

Update history

No update history recorded yet.

Related work

  • Blocked By: snapcraft#511 (confidence 98%)

    PR #518 explicitly required PR #511, which merged as commit e4936f3dc.

Related issues

Issue Project State Summary Similarity
#512 Move the login and logout methods to a client. snapcraft closed Closed unmerged as not ready; the same client extraction was later merged in snapcraft#518 via commit 927936b87 after prerequisite #511.
82%