fix(project): Use an annotated type for duration strings
Metadata
Current evaluation
PR introduces an annotated type for duration strings with stricter regex validation, inspired by snapcraft PR #5210 (ReDoS fix). Has 1 approval but 4 unresolved review comments and has been open for 596 days.
Suggested action: needs review
Reason: The PR has 4 unresolved review comments and has been open for 596 days. A maintainer should address the unresolved feedback and decide whether to merge, request further changes, or close the PR. The type safety improvement remains valid but stalled due to unaddressed review comments.
Impact:
35
Quick Win:
26.25
Staleness:
75
Complexity:
25
Confidence:
65
Issue body
Inspired by: https://github.com/canonical/snapcraft/pull/5210
This makes an annotated type for duration strings and uses a stricter regex.
- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
35
Quick Win:
26.25
Staleness:
75
Complexity:
25
Confidence:
65
|
needs review | PR introduces an annotated type for duration strings with stricter regex validation, inspired by snapcraft PR #5210 (ReDoS fix). Has 1 approval but 4 unresolved review comments and has been open for 596 days. | |
| qwen/qwen3.8-27b |
Impact:
55
Quick Win:
35.75
Staleness:
5
Complexity:
35
Confidence:
80
|
needs review | Adds an Annotated pydantic type for duration strings with a stricter regex in the project model, superseding ReDoS fix PR #5210 (GHSL-2024-323). Approved by one reviewer, CI green, 4 unresolved review comments; author requested a second review. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
85
Complexity:
15
Confidence:
80
|
close stale | Adds an annotated type for duration strings with a stricter regex. Approved by one reviewer but has two unresolved comments and has been inactive for ~10 months. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
65
Complexity:
20
Confidence:
80
|
keep open | Adds an annotated type with stricter regex for duration strings. Currently in draft state, awaiting CI verification and maintainer review. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
90
Complexity:
5
Confidence:
85
|
close stale | Introduces an annotated type for duration strings with a stricter regex. Currently in draft, awaiting final CI checks and maintainer review before being marked ready for merge. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated |
Related work
-
Related To:
snapcraft#5210
(confidence 85%)
PR body explicitly cites snapcraft PR #5210 (Fix ReDoS) as inspiration for this change.
Related issues
No related issues found above the similarity threshold.