← Back to issue list

Update craft-application

View original Github issue

Metadata

Project
snapcraft
Number
#5231
Type
issue
State
closed
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

craft-application was upgraded from 4.4.0 to 4.10.0 by merged PR #5301 (commit 886709dee), resolving the incompatible test expectations.

Resolution: closed resolved

Reason: Merged PR #5301 upgraded craft-application to 4.10.0 in commit 886709dee and resolved the test failures that had blocked the dependency update.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done craft-application currently breaks tests if updated, so it is pinned at 4.4.0. We should investigate upgrading it ### Why it needs to get done Below is done with `craft-application==4.8.2` ``` def test_project_platform_unknown_name(): """Raise an error if an empty platform is not a valid architecture.""" with pytest.raises(CraftValidationError) as raised: > snapcraft.models.project.SnapcraftBuildPlanner.model_validate( { "name": "test-snap", "base": "test-base", "build-base": "test-build-base", "platforms": {"unknown": None}, "project_type": "test-type", } ) E pydantic_core._pydantic_core.ValidationError: 2 validation errors for SnapcraftBuildPlanner E platforms.unknown.build-on E Value error, 'unknown' is not a valid DebianArchitecture [type=value_error, input_value=['unknown'], input_type=list] E For further information visit https://errors.pydantic.dev/2.8/v/value_error E platforms.unknown.build-for E Value error, 'unknown' is not a valid DebianArchitecture [type=value_error, input_value=['unknown'], input_type=list] E For further information visit https://errors.pydantic.dev/2.8/v/value_error tests/unit/models/test_projects.py:2565: ValidationError ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved craft-application was upgraded from 4.4.0 to 4.10.0 by merged PR #5301 (commit 886709dee), resolving the incompatible test expectations.
stealth/space-bunny-alpha — closed resolved craft-application was upgraded from 4.4.0 to 4.10.0 by merged PR #5301 (commit 886709dee), updating the affected validation test.
stealth/space-bunny-alpha — closed resolved craft-application was upgraded from 4.4.0 to 4.10.0 by merged PR #5301 (commit 886709dee), resolving the test failures caused by newer validation behavior.
stealth/space-bunny-alpha — closed resolved Craft-application was upgraded from 4.4.0 to 4.10.0 by merged PR #5301 (commit 886709dee), resolving the validation-test incompatibility.
stealth/space-bunny-alpha — closed resolved Updated craft-application from 4.4.0 to 4.10.0 through merged PR #5301, resolving the test failures that had prevented the dependency upgrade.
qwen/qwen3.6-35b-a3b — — Resolved by updating the test to expect ValueError instead of CraftValidationError, matching upstream craft-application 4.7.0 changes. The dependency pin was lifted and the issue closed.
qwen/qwen3.6-35b-a3b — — The craft-application dependency was updated by adjusting the failing test to expect a ValueError instead of CraftValidationError, matching upstream v4.7.0 behavior. The dependency pin was lifted and the issue closed.
qwen3.6-35b-a3b-mtp-q6 — — Resolved by updating the test to expect ValueError instead of CraftValidationError, aligning with a correct upstream change in craft-application 4.7.0. The dependency pin can now be removed.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#5301 (confidence 100%)

    Merged dependency upgrade to craft-application 4.10.0.

  • Related To: canonical/craft-application#598 (confidence 95%)

    Introduced the validation behavior requiring the affected test expectation to be updated.

Related issues

Issue Project State Summary Similarity
#5301 build(deps): update craft-application to 4.10.0 snapcraft merged Merged the craft-application 4.10.0 upgrade in #5301 (commit 886709dee), with the version also pinned in pyproject.toml by 75c57ad34.
75%
#696 build(deps): update dependency craft-application to v4.1.1 (main) rockcraft merged Merged PR #696 via commit 063fd28a, upgrading craft-application from 4.0.0 to 4.1.1 across three files.
74%
#1454 build: update craft-application charmcraft merged Merged in commit 952f070e, updating craft-application and adjusting affected test constants.
73%
#503 docs(changelog): release 4.2.5 craft-application merged Merged the changelog update for craft-application 4.2.5 via PR #503 (commit c560cc0a).
72%
#5593 build(deps): update craft-application to 5.4.0 snapcraft merged Merged PR #5593 updated craft-application to 5.4.0 across two dependency files via commit d49634269.
71%