← Back to issue list

fix(remotebuild): use the project's privacy for repos and recipes

View original Github issue

Metadata

Project
snapcraft
Number
#5238
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged PR resolves #5221 by ensuring the remote-builder respects project privacy for repositories and recipes. Incorporates a fix from craft-application PR #615. Approved by three reviewers, passed CI, and modified six files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Pulls in fixes from https://github.com/canonical/craft-application/pull/615, which fixes a bug where the remote-builder would create a public repository and recipe, even when the project is private. Fixes #5221 (CRAFT-4035)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged PR resolves #5221 by ensuring the remote-builder respects project privacy for repositories and recipes. Incorporates a fix from craft-application PR #615. Approved by three reviewers, passed CI, and modified six files.
qwen3.6-35b-a3b-mtp-q6 Merged fix ensuring the remote-builder respects project privacy for repositories and recipes. Incorporates craft-application PR #615, resolving issue #5221 where private projects incorrectly generated public artifacts.
qwen3.6-35b-a3b-mtp-q6 Merged. Resolves #5221 by integrating a fix from craft-application#615 that ensures the remote-builder respects project privacy, preventing public repository and recipe creation for private projects.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5221 remote build: use the project's privacy for repos and recipes snapcraft closed Resolved in PR #5238 and released in Snapcraft 8.6.2. Remote builds now enforce project privacy by updating craft dependencies, documenting SSH key requirements, and verifying host agent access to prevent source code exposure.
80%
#615 fix(launchpad): use the project's privacy for repos and recipes craft-application merged Merged fix ensuring the remote-builder respects project privacy when creating repositories and recipes. The backward-compatible change adds a deprecation warning for public projects and resolves issue #614 after passing CI and two approvals.
80%
#2681 fix: correctly get project name for remote builds charmcraft merged Merged after three approvals. Corrects project name retrieval for remote builds, resolving #2598. Integrated despite non-blocking type-checking warnings and two unresolved review comments.
70%
#351 fix(remotebuild): use full project name in log files craft-application merged Merged a fix ensuring remote build log files use the full project name, resolving issue #4781. Approved by three reviewers, passed CI, and updated two files.
70%