fix(core20): use importlib for local plugins
Metadata
Current evaluation
Merged in canonical/snapcraft#5290, changing core20 local plugin loading to use importlib; recorded in commits df498f0dc and 5edefe1ab.
Resolution: closed resolved
Reason: PR #5290 was merged after approval by three reviewers. The change is recorded in commits df498f0dc and 5edefe1ab.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#5290, changing core20 local plugin loading to use importlib; recorded in commits df498f0dc and 5edefe1ab. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the core20 local-plugin loading fix to use importlib; the change is recorded in commits df498f0dc and 5edefe1ab. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #5290, replacing legacy core20 local-plugin imports with importlib and removing the deprecated warning (commits 5edefe1ab, df498f0dc). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to core20 local plugin loading, replacing legacy imports with importlib and removing a deprecated warning. Approved by three reviewers with passing CI. Maintainers confirmed existing test coverage is sufficient. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Switched local plugin loading to importlib and removed a core20 deprecation warning due to potential core20 support removal. Reviewers accepted the passing build as sufficient test coverage, declining a proposed rust plugin test. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3079 cli: add plugin help for core20 | snapcraft | merged | Merged in canonical/snapcraft#3079 (04bf14915), adding core20 plugin help, Click paging, Python/nil v2 help fixes, and a core20 base fallback. | |
| #5217 Snapcraft conflates standard PyPI packages with local plugins | snapcraft | closed | Fixed by merged PR #5290: core20 local-plugin loading now uses importlib, preventing PyPI modules such as cryptography's rust package from shadowing built-in plugins. | |
| #4138 core20: support PEP 518 in the python plugin | snapcraft | closed | core20 python plugin now supports PEP 518 sources with only pyproject.toml and no setup.py, merged in PR #4087 (commit 2d596621d) and shipped in Snapcraft 8; core20 support later removed by #6241. |