fix(core20): use importlib for local plugins
Metadata
Current evaluation
Merged updates to core20 local plugin loading, replacing legacy imports with importlib and removing a deprecated warning. Approved by three reviewers with passing CI. Maintainers confirmed existing test coverage is sufficient.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to core20 local plugin loading, replacing legacy imports with importlib and removing a deprecated warning. Approved by three reviewers with passing CI. Maintainers confirmed existing test coverage is sufficient. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Switched local plugin loading to importlib and removed a core20 deprecation warning due to potential core20 support removal. Reviewers accepted the passing build as sufficient test coverage, declining a proposed rust plugin test. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged core20 local plugin loading update to use importlib. Maintainer removed a deprecation warning citing potential core20 removal. Reviewers approved merging without extra rust plugin tests, relying on existing CI coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3079 cli: add plugin help for core20 | snapcraft | merged | Merged updates to add core20 plugin help, fix python and nil plugin help for v2, enable the click pager, and default base loading to core20. Approved by reviewer and passed all CI checks. | |
| #3118 plugins: add support for local v2 plugins (core20) | snapcraft | merged | Merged after approval and passing CI. Adds local v2 plugin support (core20) via spread tests for PluginV2 and the nil v2 plugin. Approved as an enhancement following minor naming clarifications. | |
| #3082 cli: add list-plugins for core20 | snapcraft | merged | Merged addition of the list-plugins CLI command for core20. Changes remove an integration test and adapt the help command structure. Approved by one reviewer with passing CI checks. | |
| #3870 plugins command: support for core22 | snapcraft | merged | Merged changes adding core22 support to the plugins command and clarifying base selection messages. Approved by a reviewer, passed CI, and integrated into main despite a minor 0.04% coverage decrease. | |
| #5791 test: delete unused tests | snapcraft | merged | Merged removal of unused spread tests for deprecated v1 plugins. Approved by two reviewers and passed most CI checks despite one failing integration test. Cleanup of a related file deferred pending core20 support removal. |