← Back to issue list

Wrap plugin list output content

View original Github issue

Metadata

Project
snapcraft
Number
#534
Type
pull request
State
merged
Author
didrocks
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #534 as e6035c060, wrapping plugin-list content to terminal width (maximum 120 characters) and adding fallback tests for Launchpad bug 1587057.

Resolution: closed resolved

Reason: PR canonical/snapcraft#534 was merged as commit e6035c060, implementing terminal-aware plugin-list wrapping and a 120-character fallback when size detection fails.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Wrap plugin list output content up to 120 characters depending on terminal size. Added tests to ensure if detection fails, we are using the 120 characters. as well. Fixes https://bugs.launchpad.net/snapcraft/+bug/1587057. Note that it's using put cols as a subprocess. A couple of years ago, I had to look into how to get the terminal size on different platforms in a reliable way, and it seems it's the best one without duplicating a fragile logic which evolves over time as new terminals arise.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #534 as e6035c060, wrapping plugin-list content to terminal width (maximum 120 characters) and adding fallback tests for Launchpad bug 1587057.
stealth/space-bunny-alpha — closed resolved Merged #534 as commit e6035c060, wrapping plugin list output to the terminal width (up to 120 characters) and adding fallback tests for Launchpad bug 1587057.
qwen/qwen3.6-35b-a3b — — Merged after addressing review feedback and fixing tests. The change wraps plugin list output to terminal width up to 120 characters using a put cols subprocess, resolving the formatting bug and passing all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Wraps plugin list output to terminal width, capped at 120 chars. Uses tput cols for detection, updates tests, drops a redundant test, and adds ncurses-bin. Fixes Launchpad bug 1587057.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.