chore: remove issues that would cause Tiobe TICS to fail
Metadata
Current evaluation
Merged PR #5394 removed 561 lines across five files to resolve Tiobe TICS code-quality findings.
Resolution: closed resolved
Reason: PR #5394 was approved and merged into Snapcraft, deleting the code that caused Tiobe TICS to fail. Reported spread-test failures were unrelated to this cleanup.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5394 removed 561 lines across five files to resolve Tiobe TICS code-quality findings. | |
| stealth/space-bunny-alpha | — | closed resolved | Removed 561 lines across five files to resolve Tiobe TICS failures; the maintainer PR was approved and merged. Remaining spread-test failures were attributed to other issues or timeouts. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/snapcraft#5394, removing 561 lines across five files to address Tiobe TICS static-analysis failures. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to remove 561 lines across five files, resolving Tiobe TICS static analysis failures. The changes were approved and merged despite failing spread tests, which were attributed to an upstream craft-application dependency issue. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to remove code issues flagged by Tiobe TICS static analysis. Changes resolve linting and quality warnings to prevent CI failures. Unrelated spread test timeouts and dependency updates noted in comments were tracked separately. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #307 chore: address tiobe security warnings | fetch-service | merged | Merged as commit e6751a2 after two approvals to address TIOBE security warnings, although GitHub reports a zero-file diff and no CI checks. | |
| #666 chore: enable tics CRAFT-2976 | rockcraft | merged | Merged PR #666 enabled TIOBE TiCS scanning in commit 91307b42, fixing #578. | |
| #2258 chore: bring in tics relevant changes | charmcraft | merged | Merged TICS-related build and CI updates in commit 1a19ec0b (charmcraft#2258) after approval by two reviewers. | |
| #1776 chore: remove unused code | charmcraft | merged | Merged PR #1776 as commit 027696be, deleting 17,571 lines of unused code across 36 files after maintainer review and approval. | |
| #648 chore(deps): update tiobe/tics-github-action action to v4 | fetch-service | closed | Renovate PR #648 proposed upgrading tiobe/tics-github-action from v3 to v4, but was closed unmerged; main still references v3. |