← Back to issue list

Add finale tour examples and tests

View original Github issue

Metadata

Project
snapcraft
Number
#558
Type
pull request
State
merged
Author
didrocks
Labels
—
Created
Updated
Closed

Current evaluation

Merged via commit 442b4f12 (#558): added finale tour examples plus integration tests, and fixed an existing example to stamp version 2.10 as a string. Reviewers (sergiusens, come-maiz) approved despite flaky CI.

Resolution: closed resolved

Reason: The pull request itself was merged; git log for the snapcraft repo shows commit 442b4f12 "Add finale tour examples and tests (#558)" with matching message, and the change landed as described (examples + new tests, 2.10 stamped as a string). No follow-up fix or replacement PR was needed; the legacy tour test tree was simply removed later in the repo's migration to spread tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- Fix existing example by stamping 2.10 as a string. - Add finale tour examples and new tests for those. They can be enabled as they are only pulling from npm and wiki parts, which are already tested elsewhere, so should work under CI jenkins firewall rules.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged via commit 442b4f12 (#558): added finale tour examples plus integration tests, and fixed an existing example to stamp version 2.10 as a string. Reviewers (sergiusens, come-maiz) approved despite flaky CI.
stealth/space-bunny-alpha — closed resolved Merged in PR #558 via commit 442b4f127, adding finale tour examples/tests and correcting an existing example to stamp 2.10 as a string.
qwen/qwen3.6-35b-a3b — — Merged following multiple approvals and CI retest requests. The update adds finale tour examples and tests, correcting an existing example by stamping 2.10 as a string. Approved by sergiusens, fgimenez, and come-maiz before integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged external changes adding finale tour examples and tests. Fixed an existing example by stamping 2.10 as a string. Maintainers approved after multiple retest requests, and the updates were successfully integrated.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.