← Back to issue list

Ros plugin: handle stderr separated from stdout, fixes #5600

View original Github issue

Metadata

Project
snapcraft
Number
#5609
Type
pull request
State
closed
Author
MirkoFerrati
Labels
—
Created
Updated
Closed

Current evaluation

ROS stderr/stdout handling was retargeted to #5615, merged as 721d86958, and released in Snapcraft 8.10.2; #5609 was then closed.

Resolution: closed superseded

Reason: PR #5609 was superseded by merged PR #5615, which carried the fix to the 8.10 hotfix branch in commit 721d86958 and resolved #5600.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [ ] Have you successfully run `make test`? --- Fixes #5600 by separating stderr (where warnings are printed) from stdout (where the results are parsed from). If the call to rosdep returns a real error code the parameter check=True will fail the subprocess.run() call and the real error will be in stderr, so we print it. We can trust that if rosdep returns 0 -> stderr will only have warnings and we can ignore them.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded ROS stderr/stdout handling was retargeted to #5615, merged as 721d86958, and released in Snapcraft 8.10.2; #5609 was then closed.
stealth/space-bunny-alpha — closed resolved Merged in PR #5615 as commit 721d86958, separating rosdep stderr warnings from parsed stdout and resolving #5600.
qwen/qwen3.6-35b-a3b — — Superseded by PR #5615. Following a reviewer request to retarget to the hotfix/8.10 branch for a patch release, the author closed this pull request and linked to the updated version.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #5615. Fixed #5600 by separating stderr and stdout in the ROS plugin to handle warnings and errors. Retargeted to hotfix/8.10 for a patch release, replaced by PR #5615.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#5615 (confidence 100%)

    Merged replacement for #5609, carrying the ROS rosdep stdout/stderr fix into the 8.10 hotfix branch.

  • Related To: canonical/snapcraft#5600 (confidence 100%)

    ROS Jazzy rosdep failure fixed by the change merged through #5615.

Related issues

Issue Project State Summary Similarity
#5615 Ros plugin: handle stderr separated from stdout, fixes #5600 snapcraft merged Merged PR #5615 as commit 721d86958, separating rosdep stderr from parsed stdout and fixing ROS Jazzy dependency resolution in Snapcraft 8.10.2.
89%