← Back to issue list

Use pydantic instead of jsonschema for legacy project

View original Github issue

Metadata

Project
snapcraft
Number
#5654
Type
issue
State
closed
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Closed without the requested Pydantic migration; PR #5690 (f12ce847d) only updated jsonschema to 2.6.0, leaving legacy project validation on the old library.

Resolution: closed stale

Reason: No resolving implementation or closing explanation was recorded. PR #5690, merged as f12ce847d, only bumped jsonschema from 2.5.1 to 2.6.0 and did not perform the requested Pydantic conversion.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done The legacy code for parsing the project should use Pydantic models instead of validating with the `jsonschema` library. ### Why it needs to get done The current legacy code uses a pinned version of jsonschema that is very difficult to upgrade. Instead of upgrading, the code should just move over to using the more modern pydantic models.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed without the requested Pydantic migration; PR #5690 (f12ce847d) only updated jsonschema to 2.6.0, leaving legacy project validation on the old library.
stealth/space-bunny-alpha — closed stale Pydantic migration was not implemented; legacy project validation stayed on jsonschema 2.6.0 (#5690) until snapcraft_legacy was removed, making the request obsolete.
stealth/space-bunny-alpha — closed stale Closed without implementing the Pydantic migration; legacy parsing still used jsonschema 2.6.0, whose update was handled separately in #5690.
qwen/qwen3.6-35b-a3b — — Abandoned. Closed without implementation or associated pull request. The legacy codebase retains the pinned jsonschema dependency, and no migration to Pydantic models was executed.
qwen/qwen3.6-35b-a3b — — Abandoned without implementation. The legacy parsing code remains validated with jsonschema instead of migrating to Pydantic models as proposed.
qwen/qwen3.6-35b-a3b — — Abandoned. The migration from jsonschema to Pydantic for legacy project parsing was not implemented, and the issue was closed without follow-up or resolution.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation or discussion, indicating the task was abandoned. The legacy project parsing code remains unmodified.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5690 (confidence 98%)

    Merged dependency-only update to jsonschema 2.6.0; it did not resolve the migration.

Related issues

Issue Project State Summary Similarity
#5653 Use pydantic instead of jsonschema for legacy project snapcraft open Obsolete after snapcraft_legacy removal: project parsing no longer uses jsonschema; the remaining store migration is tracked separately in #5655.
82%
#5655 Use pydantic instead of jsonschema for legacy store snapcraft open Triaged enhancement to replace legacy store channel-map jsonschema validation with Pydantic; it remains open, and jsonschema 2.6.0 is still pinned.
77%