fix: show modern help text for remote-build --help in core20 projects
Metadata
Current evaluation
Closed unmerged: modern core20 remote-build help was rejected because it advertised flags unsupported by the legacy builder; #5994 later removed that builder.
Resolution: closed not a bug
Reason: No implementation from this PR was merged. A reviewer explained that modern help would advertise flags such as --project that the legacy builder rejects; the path was later eliminated by merged PR #5994 in commit b08f1a66e.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Fix (https://github.com/canonical/snapcraft/issues/5713)
- Add --help and -h to classic fallback exception check
- Ensures modern help text is displayed instead of legacy help
- Follows existing pattern for --version/-V flags
- Fixes UX issue where users see outdated help information
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed not a bug | Closed unmerged: modern core20 remote-build help was rejected because it advertised flags unsupported by the legacy builder; #5994 later removed that builder. | |
| stealth/space-bunny-alpha | — | closed superseded | PR #5806 (fix for #5713) was closed unmerged after review; maintainer @bepri noted modern help would advertise flags the legacy core20 remote builder rejects. #5713 was later closed by #5994 removing the legacy remote builder (b08f1a66e). | |
| stealth/space-bunny-alpha | — | closed stale | PR for #5713 was closed without merging; reviewers noted modern help would advertise flags the legacy remote builder could not handle. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. Despite approval and passing CI, reviewers noted the change would expose modern-only flags to legacy builders, causing unrecognized argument errors. The fix was abandoned pending further resolution. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. Reviewer deferred the change, noting that displaying modern help flags would cause errors when the legacy remote builder runs and rejects unrecognized arguments. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#5713
(confidence 100%)
Original UX issue targeted by this unmerged PR; it was closed after the legacy builder was removed.
-
Related To:
canonical/snapcraft#5676
(confidence 95%)
Removal initiative completed by PR #5994.
-
Superseded By:
canonical/snapcraft#5994
(confidence 92%)
Merged commit b08f1a66e removed the legacy remote builder and its core20-specific help path in Snapcraft 9.0.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5713 remote builder: legacy help text should never be shown | snapcraft | closed | Closed as a no-op after #5676 was completed by merged PR #5994 (b08f1a66e), which removed the legacy remote builder and its core20 help path. | |
| #6090 feat(remote-build/legacy): improve error when building with --build-for | snapcraft | merged | Merged PR #6090 improved legacy remote-builder errors for core20, clarifying that --build-for requires shorthand architectures because of Launchpad limitations. It addresses #5817 and supersedes #5819. | |
| #4895 fix(remotebuild): require core20 snaps to use the legacy remote builder | snapcraft | merged | Merged in #4895 (d9c8781a1), requiring core20 remote builds to use the legacy builder because the new builder could not parse core20 snapcraft.yaml files; fixes #4886. |