← Back to issue list

chore: drop flutter git plugin's workaround

View original Github issue

Metadata

Project
snapcraft
Number
#5838
Type
pull request
State
merged
Author
EdmilsonRodrigues
Labels
—
Created
Updated
Closed

Current evaluation

Merged #5838 (commit 729811eea), removing the temporary Flutter git workaround from #5264 after Flutter fixed the upstream bug; resolved #5756.

Resolution: closed resolved

Reason: PR #5838 was merged with approval and passing CI. Commit 729811eea removed the seven-line workaround because the upstream Flutter bug had been fixed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ X] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ X] Have you successfully run `make lint`? - [ X] Have you successfully run `make test`? --- Dropped the changes in #5264 since the upstream bug has been fixed.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #5838 (commit 729811eea), removing the temporary Flutter git workaround from #5264 after Flutter fixed the upstream bug; resolved #5756.
stealth/space-bunny-alpha — closed resolved Merged PR #5838 removed the Flutter git plugin workaround after the upstream bug was fixed, resolving issue #5756.
qwen/qwen3.6-35b-a3b — — Merged: removed Flutter git plugin workaround since the upstream bug was fixed. Approved by two reviewers with all CI checks passing. Resolves #5756.
qwen3.6-35b-a3b-mtp-q6 — — Merged to remove a Flutter git plugin workaround after the upstream bug was fixed. The change drops modifications from #5264 and resolves #5756.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5756 (confidence 100%)

    This issue requested removal of the workaround and was resolved by PR #5838.

  • Related To: canonical/snapcraft#5264 (confidence 100%)

    This earlier PR introduced the workaround that #5838 removed.

Related issues

Issue Project State Summary Similarity
#5756 Drop the flutter plugin's git workaround snapcraft closed Removed the temporary Flutter git workaround after the upstream Flutter bug was fixed; PR #5838 merged as commit 729811eea and closed #5756.
85%
#5264 fix: correct git errors in flutter plugin snapcraft merged Merged #5264 fixed Flutter plugin Git errors using Flutter's suggested workaround, closing #5258; released in Snapcraft 8.6.3 and 8.7.1.
74%
#5267 fix: correct git errors in flutter plugin snapcraft merged Merged #5267, cherry-picking #5264 into the 8.6 branch to fix Flutter precache git errors; released in Snapcraft 8.6.3 and 8.7.1.
70%