← Back to issue list

fix(models): use the correct models for all snaps

View original Github issue

Metadata

Project
snapcraft
Number
#5846
Type
pull request
State
merged
Author
lengau
Labels
PR: Run Manual Spread
Created
Updated
Closed

Current evaluation

Merged PR #5846 as commit 3249bed8e, fixing model selection to prioritize snap type over base with core22 exceptions; resolves #5843.

Resolution: closed resolved

Reason: PR #5846 was merged as commit 3249bed8e. Its description explicitly states that it fixes #5843 (SNAPCRAFT-1252) by correcting model selection for all snaps.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This redoes the model hierarchy a little bit so that we depend first on type and then on base, including our special cases for core22. Fixes: #5843 SNAPCRAFT-1252 - [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5846 as commit 3249bed8e, fixing model selection to prioritize snap type over base with core22 exceptions; resolves #5843.
stealth/space-bunny-alpha — closed resolved Merged in #5846 (3249bed8e), fixing model selection for all snaps by using type, then base, with core22 special cases; addresses #5843 (SNAPCRAFT-1252).
qwen/qwen3.6-35b-a3b — — Merged following three approvals. Restructured the model hierarchy to prioritize type over base, incorporating core22 special cases to resolve #5843. Minor CI test failures were handled separately.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Redoes model hierarchy to prioritize type over base, fixing model selection for all snaps including core22. Resolves #5843. Test failures were addressed by PR #5856 and CI rate limits.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#5843 (confidence 100%)

    The PR explicitly says it fixes this issue, which reported incorrect model selection for non-app snaps.

  • Related To: snapcraft#5856 (confidence 100%)

    Follow-up PR merged as 66b9ae9f4 to fix the snapd-bases/core20 Spread test noted during review.

Related issues

No related issues found above the similarity threshold.