← Back to issue list

Improve the store errors returning exceptions

View original Github issue

Metadata

Project
snapcraft
Number
#585
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#585 via commit ddbbdbd06, refactoring store error handling to raise exceptions and addressing LP #1594636.

Resolution: closed resolved

Reason: PR #585 was merged into snapcraft at commit ddbbdbd06. Its five-file change replaced returned store errors with exceptions and updated their handling.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1594636

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#585 via commit ddbbdbd06, refactoring store error handling to raise exceptions and addressing LP #1594636.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#585: improved store error handling by returning exceptions, updating 5 files (+93/-61) for LP #1594636.
qwen/qwen3.6-35b-a3b — — Merged changes improving store error handling by returning exceptions. Approved by maintainer come-maiz following multiple retest requests. Modifies 5 files with 93 additions and 61 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Improved store error handling by returning exceptions. Merged after multiple retest requests. Resolves LP #1594636.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4863 fix(cli): properly capture store errors snapcraft merged Merged #4863 in commit 426df7ec3, restoring legacy-style store-error capture so store failures are no longer reported as Snapcraft internal errors.
77%
#2056 Fix formatting of some store errors snapcraft merged PR #2056 by cjwatson merged as commit 1f90b2a91, fixing store error messages that were pre-formatted with str.format so raw JSON braces no longer crash SnapcraftError.__str__ (LP: #1761488).
74%
#1247 Fixing Store integration tests. snapcraft merged Merged in canonical/snapcraft#1247 as 03105a6c4, updating Store integration tests and registration error handling for the new 40-character snap-name limit.
73%
#5536 fix(store): catch credential decoding errors snapcraft merged Merged in canonical/snapcraft#5536 (commit 3784560f3), converting malformed store credential decoding failures into a user-friendly error and updating craft-store.
73%
#1765671 Strange technical error message when querying store snapcraft (launchpad) closed Fixed by snapcore/snapcraft#2094, merged as 0d8602cc5, improving handling and presentation of Store API network errors and retries.
72%
#1664716 store error list is ugly snapcraft (launchpad) closed Store error formatting improved in CLI. Resolved by error handling updates (e.g. PR #2056, commit 1f90b2a91). Maintainer confirmed Snapcraft now presents these errors better.
71%
#1627865 Snapcraft errors when releasing a snap snapcraft (launchpad) closed Resolved by improving snapcraft's error handling to check HTTP status codes before JSON decoding, alongside a fix for the underlying store race condition (bug #1610948).
70%