fix(models): clarify 'base' key is not allowed for baseless project types
Metadata
Current evaluation
Merged PR #6042 clarified that the `base` key must be removed for baseless project types and updated the corresponding unit test, fixing #4876.
Resolution: closed resolved
Reason: PR #6042 was approved and merged with all reported CI checks passing. Its validation-message change resolves the confusion reported in issue #4876.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes #4876
Improves the validation error message shown when `base` is set for baseless project types
(e.g., `type: kernel`, `base`, or `snapd`), making it clearer that `base` should be removed.
Also updates the corresponding unit test.
Tests:
- pytest tests/unit/models
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #6042 clarified that the `base` key must be removed for baseless project types and updated the corresponding unit test, fixing #4876. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged validation-message update clarifying that base must be removed for baseless project types, with a corresponding unit-test update; fixes #4876. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #6042 (fc867f0df), clarifying that base is invalid for baseless project types and updating validation tests. Fixes #4876. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes clarifying that the base key is invalid for baseless project types. Updated validation error messages and unit tests were approved by three reviewers, passed all CI checks, and incorporated requested formatting updates before merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after addressing formatting and linting feedback. Updated validation error messages to clarify that the base key is invalid for baseless project types and updated corresponding unit tests. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#4876
(confidence 100%)
Original issue explicitly identified as fixed by PR #6042.
Related issues
No related issues found above the similarity threshold.