← Back to issue list

refactor: desktop extension GPU functions into a base class

View original Github issue

Metadata

Project
snapcraft
Number
#6077
Type
pull request
State
merged
Author
Saviq
Labels
PR: Run Manual Spread
Created
Updated
Closed

Current evaluation

Refactor PR merged as commit 9171fb25f, collecting desktop extension GPU content-interface functionality into a base class, cutting duplication and paving the way for a standalone GPUExtension. Unblocked the GPU extension work in #6082.

Resolution: closed resolved

Reason: The PR itself was merged to main as commit 9171fb25f ('refactor: desktop extension GPU functions into a base class (#6077)', +602/-503 across 19 files), approved by 2 reviewers after bepri confirmed the desktop extension spread tests passed and that the remaining failures were unrelated infrastructure issues.

Evaluated by: mr-cal-bot

No scores available.

Issue body

NB: this comes behind #5985, best reviewed per commit This collects the functionality related to GPU content interfaces in a base class, both reducing duplication and in preparation for making `GPUExtension` a standalone one. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. `node` went wrong :shrug: - [x] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Refactor PR merged as commit 9171fb25f, collecting desktop extension GPU content-interface functionality into a base class, cutting duplication and paving the way for a standalone GPUExtension. Unblocked the GPU extension work in #6082.
stealth/space-bunny-alpha — closed resolved PR #6077 merged, consolidating desktop-extension GPU functions into a base class to reduce duplication and prepare for a standalone GPU extension.
qwen/qwen3.6-35b-a3b — — Merged after refactoring desktop extension GPU functions into a base class to reduce duplication and prepare for a standalone GPU extension. Reviewers approved despite unrelated CI flakiness, confirming no behavioral changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactor consolidating desktop extension GPU functions into a base class to reduce duplication and prepare for a standalone GPUExtension. Approved after reviewers confirmed unrelated flaky test failures.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5985 (confidence 92%)

    Explicitly stated as the preceding PR in the series; merged as commit 3d4c86a73 adding the GPU linter.

  • Related To: canonical/snapcraft#6082 (confidence 90%)

    GPU extension for core22/core24, merged as d0fe5f2b5 after this prerequisite refactor; also caused the review confusion noted in the comments.

Related issues

Issue Project State Summary Similarity
#6082 feat: gpu extension for core22 and core24 snapcraft merged Merged PR #6082 as commit d0fe5f2b5, adding the GPU extension for core22 and core24 after prerequisite refactor #6077.
70%