fix(init): allow long directory names
Metadata
Current evaluation
Merged #6216 (commit 254546337), fixing snapcraft init to use a valid default for invalid directory-derived names while preserving validation of explicit names; closes #6093.
Resolution: closed resolved
Reason: PR #6216 was merged as commit 254546337. It added long-directory-name coverage and resolves issue #6093 by falling back to a valid default only for directory-derived names.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Summary
- validate snap names during init name resolution so directory-derived names can fall back to the default
- keep explicit invalid names failing with Snapcraft's snap name validation
- add coverage for long working directory names
Issue
Closes #6093
Validation
- pytest -q tests/unit/services/test_init.py tests/unit/commands/test_init.py -rs
- ruff check snapcraft/services/init.py tests/unit/services/test_init.py tests/unit/commands/test_init.py
- ruff format snapcraft/services/init.py tests/unit/services/test_init.py tests/unit/commands/test_init.py
- git diff --check
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #6216 (commit 254546337), fixing snapcraft init to use a valid default for invalid directory-derived names while preserving validation of explicit names; closes #6093. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #6216 (commit 254546337): snapcraft init now falls back to a valid default for long directory names while preserving validation of explicit invalid names; closes #6093. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for init name resolution allowing long directory names by falling back to default snap names, while preserving explicit validation for invalid names. Closes #6093. Approved and merged despite unrelated CI failures. | |
| qwen/qwen3.8-27b |
Impact:
45
Quick Win:
32
Staleness:
5
Complexity:
30
Confidence:
80
|
needs review | Fixes snapcraft init failing when the working directory name exceeds 40 chars by validating snap names and falling back to the default for directory-derived names. Approved by 2 reviewers; changes already present in the codebase; 2 unrelated integration-spread CI checks failing. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
65
Complexity:
15
Confidence:
75
|
needs review | Validates snap names during init to allow long directory names to fall back to defaults. Adds unit tests. Currently pending maintainer review with zero approvals; reported CI failures are unrelated. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
65
Complexity:
15
Confidence:
80
|
needs review | Fixes snap name validation during init to handle long working directory names by falling back to defaults. Includes unit tests. PR has been inactive for 71 days with unrelated CI failures reported by the author. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated |
Related work
-
Related To:
snapcraft#6093
(confidence 100%)
Original long-working-directory-name failure explicitly closed by PR #6216.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6103 init: normalize long directory-derived snap names | snapcraft | closed | Closed unmerged and superseded by PR #6216 (commit 254546337), which fixed init for long directory-derived names while retaining strict explicit-name validation. | |
| #6093 `snapcraft init` fails when the working directory's name is longer than 40 characters | snapcraft | closed | Fixed by merged PR canonical/snapcraft#6216 (commit 254546337): snapcraft init now uses the default snap name when a directory-derived name exceeds 40 characters. |