← Back to issue list

fix(test): correct match string in try test

View original Github issue

Metadata

Project
snapcraft
Number
#6224
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #6224 in commit 78ef8569b, correcting the snapcraft try test match string after #6193 changed the effective-base output.

Resolution: closed resolved

Reason: The one-line test correction was approved and merged as commit 78ef8569b, restoring the expected match after the behavior change in #6193.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes a test string that became invalidated in #6193 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #6224 in commit 78ef8569b, correcting the snapcraft try test match string after #6193 changed the effective-base output.
stealth/space-bunny-alpha — closed resolved Merged PR #6224 as commit 78ef8569b, correcting a try test match string invalidated by PR #6193.
stealth/space-bunny-alpha — closed resolved Merged #6224 in commit 78ef8569b, correcting a try-test match string invalidated by #6193.
qwen/qwen3.6-35b-a3b — — Merged a one-line fix correcting an invalidated test string from PR #6193. Approved by two reviewers and passed CI checks before integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix correcting a test string invalidated by PR #6193. The change updates the match string in the try test to restore test validity.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/snapcraft#6193 (confidence 100%)

    Its effective-base error-message change invalidated the assertion corrected by #6224.

Related issues

Issue Project State Summary Similarity
#6186 `snapcraft try` error is outdated snapcraft closed Fixed by merged PR #6193 (commit bcae1c3ed): snapcraft try now reports the effective project base, with core24 and core26 test coverage.
74%
#6193 fix: snapcraft try error shows effective base snapcraft merged Merged PR #6193 fixed `snapcraft try` to report the project's effective base via `get_effective_base()`, with core24 and core26 test coverage, in commit bcae1c3ed.
73%
#4662 fix(test): do not create 2 snapcraft.yaml and confuse location snapcraft merged Merged PR #4662 as commit a50b0617a, fixing test fixture paths so tests do not create duplicate root and /snap manifests that cause ambiguous hook lookup.
72%