← Back to issue list

feat: deprecation warning for snap_daemon system username

View original Github issue

Metadata

Project
snapcraft
Number
#6250
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds typed snap_daemon deprecation metadata and a craft-cli warning; core tests pass, but schema and integration checks fail and 3 review comments remain unresolved.

Suggested action: needs review

Reason: The feature addresses open issue #5448 and the fast, minimum-dependency, and slow unit suites pass. However, the PR has been inactive for 139 days with no reviews, 3 unresolved review comments, and failures in diff-schema, Canonical CLA, OSV-scanner, and three integration checks, so maintainer attention and CI triage are still required.

Evaluated by: mr-cal-bot

Impact: 42 Quick Win: 10 Complexity: 28 Confidence: 87 Actionability: 34

Issue body

Add a SystemUsernames pydantic model with snap_daemon marked as deprecated, so the JSON schema exposes 'deprecated: true' on that key. Also emit a runtime warning via craft-cli when snap_daemon is used. Fixes: https://github.com/canonical/snapcraft/issues/5448 Describe your changes. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 42
Quick Win: 10
Complexity: 28
Confidence: 87
Actionability: 34
needs review Adds typed snap_daemon deprecation metadata and a craft-cli warning; core tests pass, but schema and integration checks fail and 3 review comments remain unresolved.
qwen/qwen3.6-35b-a3b
Impact: 35
Quick Win: 5
Complexity: 25
Confidence: 45
Actionability: 20
keep open Adds deprecation warning for snap_daemon system username in JSON schema and runtime. Open 127 days with 0 reviewer engagement, 3 unresolved review comments, and failing CI (diff-schema, CLA, integration tests).
qwen/qwen3.8-27b
Impact: 35
Quick Win: 19
Staleness: 50
Complexity: 45
Confidence: 75
needs review Adds SystemUsernames pydantic model marking snap_daemon deprecated in JSON schema and emits runtime warning via craft-cli. Fixes snapcraft#5448. Pending review with 3 unresolved comments; CI failing on diff-schema and CLA.
qwen/qwen3.6-35b-a3b
Staleness: 45
Complexity: 20
Confidence: 75
needs review Adds a pydantic model marking snap_daemon as deprecated, updates JSON schema, and emits a runtime warning. Currently awaiting review with 0 comments and 67 days of inactivity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 20
Confidence: 75
needs review Adds a pydantic model and runtime deprecation warning for the snap_daemon system username. PR has been inactive for 53 days with no comments or CI status.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#5448 (confidence 99%)

    This open issue requests the snap_daemon deprecation warning implemented by the PR.

Related issues

Issue Project State Summary Similarity
#5448 Add deprecation warning for the `snap_daemon` system username snapcraft open Maintainer-filed enhancement (triaged) to warn when `snap_daemon` appears in system-usernames, per snapd's deprecation. Still unimplemented on HEAD; PR #6250 exists but is open with failing CI and unresolved review comments.
78%