feat: deprecation warning for snap_daemon system username
Metadata
Current evaluation
Adds SystemUsernames pydantic model marking snap_daemon deprecated in JSON schema and emits runtime warning via craft-cli. Fixes snapcraft#5448. Pending review with 3 unresolved comments; CI failing on diff-schema and CLA.
Suggested action: needs review
Reason: The PR has 3 unresolved review comments and failing CI checks including diff-schema (directly relevant to the schema deprecation change) and Canonical CLA. Target issue #5448 remains open, so the PR is still relevant but needs maintainer attention to address review feedback and CI failures before it can be merged.
Impact:
35
Quick Win:
19.25
Staleness:
50
Complexity:
45
Confidence:
75
Issue body
Add a SystemUsernames pydantic model with snap_daemon marked as deprecated, so the JSON schema exposes 'deprecated: true' on that key. Also emit a runtime warning via craft-cli when snap_daemon is used.
Fixes: https://github.com/canonical/snapcraft/issues/5448
Describe your changes.
---
- [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.8-27b |
Impact:
35
Quick Win:
19.25
Staleness:
50
Complexity:
45
Confidence:
75
|
needs review | Adds SystemUsernames pydantic model marking snap_daemon deprecated in JSON schema and emits runtime warning via craft-cli. Fixes snapcraft#5448. Pending review with 3 unresolved comments; CI failing on diff-schema and CLA. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
45
Complexity:
20
Confidence:
75
|
needs review | Adds a pydantic model marking snap_daemon as deprecated, updates JSON schema, and emits a runtime warning. Currently awaiting review with 0 comments and 67 days of inactivity. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
45
Complexity:
20
Confidence:
75
|
needs review | Adds a pydantic model and runtime deprecation warning for the snap_daemon system username. PR has been inactive for 53 days with no comments or CI status. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
40
Complexity:
20
Confidence:
85
|
needs review | Adds a deprecation warning and JSON schema flag for the snap_daemon system username using a pydantic model and craft-cli runtime warning. Currently open, unreviewed, and inactive for 31 days. Requires triage, checklist completion, and maintainer approval before merge. |
Update history
No update history recorded yet.
Related work
-
Caused By:
snapcraft#5448
(confidence 95%)
PR body explicitly states 'Fixes: https://github.com/canonical/snapcraft/issues/5448'
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5448 Add deprecation warning for the `snap_daemon` system username | snapcraft | open | Enhancement to emit a deprecation warning when the deprecated `snap_daemon` system username is used in snapcraft.yaml. Triaged by a maintainer; an open PR (#6250) explicitly fixes it and is pending review with CI failing. |