← Back to issue list

fix: error when export-login target file already exists

View original Github issue

Metadata

Project
snapcraft
Number
#6302
Type
pull request
State
merged
Author
mbeijen
Labels
Created
Updated
Closed

Current evaluation

⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.

Fixes an internal error when running export-login twice to the same file. Currently under review with one approval and three unresolved comments. CI passes on most platforms but fails on Ubuntu 22.04/26.04 integration tests and security scans.

Suggested action: needs review

Reason: The PR addresses a targeted bug with low complexity and shows recent activity. It requires maintainer review to address three unresolved comments and investigate failing CI checks on newer Ubuntu versions before merging.

Staleness: 40 Complexity: 15 Confidence: 80

Issue body

Closes #6301 Makes sure there is no 'internal error' when generating credentials twice to the same file. (update: by exiting with an explicit error) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Staleness: 40
Complexity: 15
Confidence: 80
needs review Fixes an internal error when running export-login twice to the same file. Currently under review with one approval and three unresolved comments. CI passes on most platforms but fails on Ubuntu 22.04/26.04 integration tests and security scans.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 20
Confidence: 75
needs review Fixes an internal error when running export-login twice to the same file. Passes lint and tests, but has no maintainer feedback after 17 days.
qwen3.6-35b-a3b-mtp-q6
Staleness: 0
Complexity: 15
Confidence: 85
needs review Fixes internal error when running export-login twice to the same file. Awaits maintainer review.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated

Related issues

Issue Project State Summary Similarity
#3797 store: export-login with legacy snapcraft merged Merged to main. Resolves export-login to stop prioritizing legacy credentials during export. Approved, passed CI, and maintained 100% coverage.
72%
#3799 export-login: clarify use of exported tokens snapcraft merged Merged clarification on exported token usage in export-login. Updated two files (+50/-3 lines). CI passed with 100% diff coverage. Unrelated upload failures and a minor coverage drop did not block the merge.
71%