fix(commands/promote): exit non-zero when promotion is cancelled
Metadata
Current evaluation
⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.
Merged as a squash commit. Fixes #6294 by ensuring the promote command exits non-zero when cancelled. Updates documentation to guide CI workflows previously relying on the SNAPCRAFT_HAS_TTY workaround for #5958. Approved by three reviewers.
Suggested action: —
No scores available.
Issue body
- Exit non-zero when promotion is cancelled by the user.
- Provide guidance for fixing CI workflows that relied on `SNAPCRAFT_HAS_TTY` to workaround #5958.
Fixes #6294
(SNAPCRAFT-1359)
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [x] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged as a squash commit. Fixes #6294 by ensuring the promote command exits non-zero when cancelled. Updates documentation to guide CI workflows previously relying on the SNAPCRAFT_HAS_TTY workaround for #5958. Approved by three reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
0
Complexity:
20
Confidence:
90
|
needs review | Fixes non-zero exit code on cancelled promotion and updates CI guidance. Author addressed unrelated CI failures. Ready for maintainer review. |
Update history
| Date | Change |
|---|---|
| updated |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6218 refactor: migrate promote command | snapcraft | merged | Migrated the promote command from snapcraft_legacy to the main codebase as a near-verbatim port to preserve complex legacy behaviors. Approved by two reviewers and merged after passing most CI checks, despite one store integration test failure. |