← Back to issue list

feat(confdb-schemas): add filters and parameters

View original Github issue

Metadata

Project
snapcraft
Number
#6406
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #6406 (c1cd30347) added ConfDB schema filters and parameters, closing #5955 and shipping in Snapcraft 9.2.

Resolution: closed resolved

Reason: The approved PR was merged with commit c1cd30347, adding filter and parameter marshalling coverage for ConfDB schemas. It resolved SNAPCRAFT-1269 and was included in Snapcraft 9.2.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Adds filters and parameters to confdb schemas. This is getting exercised indirectly the spread test - the confdb-schema used by the spread test has a parameter and filter, proving that it can be marshalled, unmarshalled, and sent to and from the Snap store. (SNAPCRAFT-1269) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #6406 (c1cd30347) added ConfDB schema filters and parameters, closing #5955 and shipping in Snapcraft 9.2.
stealth/space-bunny-alpha — closed resolved Merged #6406, adding filters and parameters to confdb schemas in Snapcraft 9.2, closing #5955 (SNAPCRAFT-1269). The maintainer confirmed store-test failures were unrelated.
qwen/qwen3.6-35b-a3b — — Merged after adding filters and parameters to confdb schemas. Approved by two reviewers. CI passed despite unrelated store test failures. Changes span five files (+103/-4 lines) and address SNAPCRAFT-1269.
qwen/qwen3.8-27b
Impact: 40
Quick Win: 28
Staleness: 5
Complexity: 30
Confidence: 80
needs review Adds filters and parameters to confdb schemas, exercised indirectly by the spread test. Approved by 2 reviewers, 3 unresolved review comments, CI mostly passing with 2 failing store/spread jobs the author says are unrelated.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 32
Staleness: 5
Complexity: 30
Confidence: 80
needs review Adds filters and parameters fields to confdb schema models, exercised via spread tests that marshal and send schemas to the Snap store. Approved by one reviewer; 2 unresolved review comments; 2 CI checks failing (author says store failures are unrelated).
qwen/qwen3.8-27b
Impact: 45
Quick Win: 32
Staleness: 5
Complexity: 30
Confidence: 75
needs review Adds filters and parameters fields to confdb schema models, exercised by a spread test that round-trips a schema with a parameter and filter through the Snap store. Approved by 1 reviewer, 1 unresolved review comment, 2 unrelated store CI failures.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 29
Staleness: 5
Complexity: 35
Confidence: 75
needs review Adds filters and parameters to confdb schemas, exercised indirectly via the spread test to prove marshalling and store round-trip. Fresh PR (0 days), pending review with 1 unresolved comment; 2 CI checks failing (store + 22.04 spread) but author says store failures are unrelated.
qwen/qwen3.8-27b
Impact: 40
Quick Win: 24
Staleness: 5
Complexity: 40
Confidence: 55
needs review Adds filters and parameters to confdb schemas in snapcraft. Brand new PR (0 days), 5 files changed (+103/-4), pending review with 0 reviewers. Two CI checks failing: integration-spread-tests-store and integration-spread-tests (ubuntu-22.04-64).
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 30
Confidence: 85
needs review Adds parameters (filters) to confdb schemas, enabling marshalling and store communication. Currently pending maintainer review with one unresolved comment and several CI jobs still running.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 30
Confidence: 90
needs review Adds parameters (filters) to confdb schemas to enable marshalling and unmarshalling with the Snap store. Currently awaiting maintainer review with one unresolved comment and pending self-hosted CI jobs.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 85
needs review Adds parameters/filters to confdb schemas to enable marshalling and store communication. Currently pending maintainer review with one unresolved comment, zero approvals, and CI failing on spread tests and lint.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 30
Confidence: 85
needs review Adds parameters/filters to confdb schemas with marshalling support. Currently pending maintainer review, has 2 unresolved comments, and fails the lint / files CI check.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 90
needs review Adds parameters to confdb schemas for marshalling and store communication. Currently pending maintainer review with two unresolved comments. CI shows a failing lint check and pending integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 25
Confidence: 85
needs review Adds parameters and filters to confdb schemas for marshalling and store communication. Currently pending maintainer review with one failing lint check and several CI jobs in progress.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 85
needs review Adds parameters/filters to confdb schemas for Snap store marshalling. Currently pending review with 2 unresolved comments and a failing lint check.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 25
Confidence: 90
needs review Adds parameters (filters) to confdb schemas, enabling marshalling and store communication. Currently pending maintainer review with all CI checks passing and no comments.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: snapcraft#5955 (confidence 99%)

    ConfDB filter-support issue #5955 was closed by this merged PR.

Related issues

Issue Project State Summary Similarity
#5955 Support confdb filters snapcraft closed Confdb filter parameters were added by merged PR #6406 (commit c1cd30347) and included in Snapcraft 9.2.
83%
#5477 docs: link to confdb schema docs snapcraft merged Merged #5477 (commit 6fa334402), adding links to snapd's new confdb schema documentation.
72%
#5353 Rename confdbs to confdb-schema snapcraft closed Renamed confdbs to confdb-schema in PR #5356 (commit de5ab3e29); Snapcraft 8.9 release notes document the updated commands.
71%