← Back to issue list

metrics: list valid metric names in help output

View original Github issue

Metadata

Project
snapcraft
Number
#6428
Type
pull request
State
open
Author
distopicx01-ops
Labels
—
Created
Updated
Closed
—

Current evaluation

Makes `snapcraft metrics --help` list valid `--name` metric values from MetricName;2-line change, CLA green and approved, but reviewer asked to reformat the long help into an overview list and the author has not pushed that rework yet.

Suggested action: needs review

Reason: The diff is +2/-1 lines on metrics command help only, CI shows 'Canonical CLA' passing with no failures, and the PR is marked approved by 1 reviewer, addressing the open enhancement issue #6401 (which itself had a maintainer-approved hardcoded-list approach). However, reviewer @mr-cal commented 'Perhaps it would look better in the overview as a list?' and the author replied 'I'll refactor it to look cleaner as a list in the overview', leaving 1 unresolved review comment and no follow-up commit for 10 days, so a reformat iteration is still expected before merge.

Evaluated by: mr-cal-bot

Impact: 25 Quick Win: 14 Complexity: 8 Confidence: 72 Actionability: 60

Issue body

Updates the help text for the `--name` argument in the `metrics` command to dynamically list all valid metric names from `MetricName`. This improves the CLI UX by preventing users from having to check external documentation for valid options. Fixes #6401

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 25
Quick Win: 14
Complexity: 8
Confidence: 72
Actionability: 60
needs review Makes `snapcraft metrics --help` list valid `--name` metric values from MetricName;2-line change, CLA green and approved, but reviewer asked to reformat the long help into an overview list and the author has not pushed that rework yet.
stealth/space-bunny-alpha
Impact: 28
Quick Win: 12
Complexity: 12
Confidence: 94
Actionability: 50
keep open Lists valid metric names in metrics --name help for #6401. CLA passes, but a formatting request remains unresolved; the author says they will reformat the long output into an overview list.
qwen/qwen3.6-35b-a3b
Impact: 25
Quick Win: 20
Complexity: 5
Confidence: 90
Actionability: 85
needs review Updates metrics command help text to dynamically list valid metric names from MetricName enum, improving CLI UX. Open, awaiting review, CLA pending.

Update history

Date Change
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: snapcraft#6401 (confidence 95%)

    The PR body states 'Fixes #6401', the open enhancement issue for `snapcraft metrics` not listing valid `--name` values; issue triage noted a hardcoded list now with a store-backed `list-metrics` command later.

Related issues

Issue Project State Summary Similarity
#6401 `snapcraft metrics` CLI requires `--name` but does not list the possible values snapcraft open Enhancement: `snapcraft metrics --help` omits the valid `--name` metric values, forcing users to check store docs. Triaged, assigned to a contributor, with maintainer-approved approach: hardcoded list in help now, store-backed `list-metrics` command later.
81%