Feature/ant plugin test
Metadata
Current evaluation
Merged in #644 via commit 01273e718: ant plugin switched from self.run() copy/mkdir shell calls to shutil.copy()/os.makedirs(), plus new Ant plugin tests (LP bug 1600410).
Resolution: closed resolved
Reason: The PR was merged into snapcraft as commit 01273e718 ('ant plugin: use python std libraries and add tests'), after sergiusens approved it ('ok to test') following a minor os.link suggestion. The change replaced self.run() copy/mkdir calls with Python stdlib calls and added unit tests for the Ant plugin.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the ant plugin to remove calls to self.run() for copy and mkdir -p
Use of shutil.copy() and os.makedirs.
Added ant test file.
https://bugs.launchpad.net/snapcraft/+bug/1600410
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in #644 via commit 01273e718: ant plugin switched from self.run() copy/mkdir shell calls to shutil.copy()/os.makedirs(), plus new Ant plugin tests (LP bug 1600410). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #644 via commit 01273e718, replacing Ant copy and mkdir shell calls with Python APIs and adding Ant plugin tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updated ant plugin to replace self.run() calls with shutil.copy() and os.makedirs(), adding tests. Incorporated reviewer feedback to use os.link() for improved disk efficiency. Approved and merged after resolving one comment. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after incorporating feedback to use os.link for disk efficiency. The ant plugin now uses shutil.copy and os.makedirs instead of self.run, and includes new tests to resolve bug 1600410. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#752
(confidence 40%)
Later Ant plugin enhancement (commit e3fe0ed62) building on the same plugin; not the resolving change.
Related issues
No related issues found above the similarity threshold.