← Back to issue list

fix(meta): don't duplicate assumes already declared by the project

View original Github issue

Metadata

Project
snapcraft
Number
#6445
Type
pull request
State
closed
Author
wak327
Labels
—
Created
Updated
Closed

Current evaluation

PR #6445 was closed unmerged with review still pending; its deduplication fix was not integrated, and bug #4931 remains open.

Resolution: closed stale

Reason: PR #6445 was closed without merge while review remained pending with zero reviewers, with no resolving commit. Current code still concatenates declared and computed assumes, and #4931 remains open.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Snapcraft adds `command-chain` to `assumes` when an app or hook uses `command-chain`, and `snapd2.74` when an app uses `success-exit-status`. If the project already declared the same feature, the generated `snap.yaml` listed it twice, and the store rejects the upload: ``` lint-snap-v2:snap_schema Error found while validating snap.json::$.assumes: ['command-chain', 'command-chain'] has non-unique elements ``` The declared and computed values are now combined as a set before sorting, so each feature is listed once. Fixes #4931 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #6445 was closed unmerged with review still pending; its deduplication fix was not integrated, and bug #4931 remains open.
qwen/qwen3.8-27b — closed stale PR to deduplicate assumes entries in snap.yaml (fixing #4931) was closed without merge; review still pending with 0 reviewers and issue #4931 remains open.
stealth/space-bunny-alpha
Impact: 45
Quick Win: 31
Complexity: 12
Confidence: 86
Actionability: 78
needs review Fixes duplicate `assumes` entries in generated snap.yaml by unioning project-declared and Snapcraft-computed features as a set before sorting; addresses #4931 (store upload rejection). Awaiting review.

Update history

Date Change
closed
updated
created

Related work

  • Related To: canonical/snapcraft#4931 (confidence 100%)

    PR #6445 explicitly targeted this open duplicate-assumes bug but was closed unmerged.

Related issues

No related issues found above the similarity threshold.