fix(core22): don't warn about manifest arguments set by env vars
Metadata
Current evaluation
Closed unmerged without a resolving commit. The proposed core22 fix suppressed manifest-option warnings when values came from SNAPCRAFT environment variables; issue #4916 remains open.
Resolution: closed stale
Reason: PR #6452 was closed without merge, with no closing maintainer explanation or resolving commit recorded. The underlying bug in #4916 remains open, indicating the proposed fix was abandoned rather than delivered.
Evaluated by: mr-cal-bot
No scores available.
Issue body
For core22 projects, `--enable-manifest` and `--manifest-image-information` default to the `SNAPCRAFT_BUILD_INFO` and `SNAPCRAFT_IMAGE_INFO` environment variables. The variables are the documented replacement for these deprecated arguments, but Snapcraft showed the deprecation warnings whenever the values were set, including when they only came from the environment:
```
'--enable-manifest' is deprecated, and will be removed in core24.
'--manifest-image-information' is deprecated, and will be removed in core24.
```
The warnings are now only shown when the values don't come from the environment variables. This works on the host and in the build instance, since the variables are forwarded into the instance. Passing the arguments directly still shows the warnings.
Fixes #4916
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged without a resolving commit. The proposed core22 fix suppressed manifest-option warnings when values came from SNAPCRAFT environment variables; issue #4916 remains open. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged; the proposed core22 fix for spurious manifest-option warnings was not integrated, and #4916 remains open. | |
| qwen/qwen3.8-27b | — | closed superseded | Closed without merge. Fixes #4916 (spurious core22 deprecation warnings for --enable-manifest/--manifest-image-information set via SNAPCRAFT_BUILD_INFO/SNAPCRAFT_IMAGE_INFO), but #4916 stays open and the fix is tracked in open PR #6452, so this PR was superseded. | |
| qwen/qwen3.8-27b | — | closed stale | PR to suppress spurious core22 deprecation warnings for --enable-manifest/--manifest-image-information when values come from SNAPCRAFT_BUILD_INFO/SNAPCRAFT_IMAGE_INFO env vars. Closed unmerged with 0 reviewers; linked issue #4916 remains open. | |
| stealth/space-bunny-alpha |
Impact:
25
Quick Win:
13
Complexity:
30
Confidence:
78
Actionability:
74
|
needs review | Fixes core22 spurious deprecation warnings for --enable-manifest/--manifest-image-information when values come from SNAPCRAFT_BUILD_INFO/SNAPCRAFT_IMAGE_INFO. Fresh PR from wak327 (+152/-12, 2 files), CLA signed, awaiting maintainer review. |
Update history
| Date | Change |
|---|---|
| closed | |
| created |
Related work
-
Related To:
canonical/snapcraft#4916
(confidence 100%)
The PR claimed to fix this still-open deprecation-warning bug, but its changes were never merged.
-
Caused By:
canonical/snapcraft#4618
(confidence 85%)
Merged as commit e426d07a3 and introduced deprecation of the two manifest options in core22.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4916 `--enable-manifest` and `--manifest-image-information` deprecation warnings display when options haven't been used | snapcraft | open | core22: spurious "'--enable-manifest'/'--manifest-image-information' is deprecated" warnings appear when only SNAPCRAFT_BUILD_INFO/SNAPCRAFT_IMAGE_INFO env vars are set. Confirmed by mr-cal; fix PR #6452 was closed unmerged, so still unfixed. |