← Back to issue list

docs: replace Discord pre-built example with Signal Desktop source-build

View original Github issue

Metadata

Project
snapcraft
Number
#6506
Type
pull request
State
open
Author
0x5t4l1n
Labels
—
Created
Updated
Closed
—

Current evaluation

Replaces the Discord pre-built-binary example with a Signal Desktop source build using isolated pnpm and explicit release staging. Commit c308179 addresses four comments, but Canonical CLA still fails and no maintainer has reviewed it.

Suggested action: needs review

Reason: The author states that commit c308179 addressed all four review comments, so the change is awaiting maintainer re-review. However, the metadata still reports four unresolved comments, there are no reviewers, and the only reported CI check, Canonical CLA, is failing, so the PR is not immediately mergeable.

Evaluated by: mr-cal-bot

Impact: 42 Quick Win: 14 Complexity: 30 Confidence: 88 Actionability: 48

Issue body

## Summary Closes #5944. The existing "Craft a snap of an existing binary" section uses Discord as its example. Discord is just a `dump` of a pre-built `.deb` — it shows how to repackage a binary, not how to build an Electron application from source. Replace it with a **Signal Desktop** example that pulls the upstream Git repository and compiles the app using `pnpm`. This demonstrates the pattern readers are likely to need: - A dedicated `node-runtime` part that installs `pnpm` in isolation - A `signal-desktop` part that checks out the source tag, installs dependencies with `--frozen-lockfile`, and runs the release build script The accompanying prose is updated to explain the two-part structure and why the isolation step matters. The `electron-quick-start` / `electron-builder` section at the top of the page is unchanged.

Evaluation history

Date Model Scores Action Summary
minimax/minimax-m3.1-flash:free
Impact: 42
Quick Win: 14
Complexity: 30
Confidence: 88
Actionability: 48
needs review Replaces the Discord pre-built-binary example with a Signal Desktop source build using isolated pnpm and explicit release staging. Commit c308179 addresses four comments, but Canonical CLA still fails and no maintainer has reviewed it.

Update history

Date Change
updated
updated
created

Related work

  • Likely Fixed By: snapcraft#5944 (confidence 100%)

    The PR explicitly says it closes issue #5944, which requested replacing the Discord example with a Signal Desktop source-build example.

Related issues

No related issues found above the similarity threshold.