fix: skip ELF files with no dynamic string table
Metadata
Current evaluation
Fixes crash on Guile .go ELF files by skipping those without a dynamic string table. Includes unit test. Awaiting maintainer review.
Suggested action: needs review
Reason: The PR fixes a crash (AssertionError on Guile .go files) referenced in issue #6527 with a small, targeted change (+42/-0 lines) and includes a unit test. It has no reviewers yet and CI status is unclear, so it needs maintainer review before merging. The author also asks which branch to target (main vs hotfix/9.2).
Evaluated by: mr-cal-bot
Impact:
55
Quick Win:
28
Complexity:
15
Confidence:
75
Actionability:
60
Issue body
Fixes #6527
Snapcraft crashed with an AssertionError on Guile .go files, which are valid ELF files with no string table in the dynamic section. Now snapcraft skips them with a short message, like other ELF files it can't read.
I added a unit test and checked it on a real Guile file (gdb.go): it crashed before and is skipped now. I haven't built the gnucash snap. The same 34 unit tests fail on my machine with and without my change.
Should this go to main or hotfix/9.2, and does it need a release note?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
28
Complexity:
15
Confidence:
75
Actionability:
60
|
needs review | Fixes crash on Guile .go ELF files by skipping those without a dynamic string table. Includes unit test. Awaiting maintainer review. |
Update history
| Date | Change |
|---|---|
| updated | |
| created |
Related work
-
Likely Fixed By:
snapcraft#6527
(confidence 95%)
This PR explicitly fixes issue #6527, which reports the same crash on Guile .go ELF files.
Related issues
No related issues found above the similarity threshold.