← Back to issue list

Special handling for pc files for conflicts

View original Github issue

Metadata

Project
snapcraft
Number
#676
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged fix for LP #1604472 adding special handling for .pc files in the conflict checker. Skips os.linking for .pc files to handle differing prefixes in parts installdir. Approved and merged after passing CI checks.

Suggested action:

No scores available.

Issue body

The .pc files can have a different prefix when coming from the the parts installdir and messes up the conflict checker so we handle this case when doing the check for .pc files. To make this work correctly we need to skip os.linking when dealing with .pc files. LP: #1604472 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for LP #1604472 adding special handling for .pc files in the conflict checker. Skips os.linking for .pc files to handle differing prefixes in parts installdir. Approved and merged after passing CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Resolves conflict checker issues with .pc files by handling differing prefixes and skipping linking checks. Approved by reviewers and integrated.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds special handling for .pc files in the conflict checker by skipping os.linking to account for differing prefixes in parts installdir. Approved and merged after maintainer review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#977 fix: Honor the ${pcfiledir} entries in pkgconfig craft-parts merged Merged after approval and CI. Fixes pkgconfig handling to honor ${pcfiledir} entries for relocatable .pc files. Spelling errors were resolved via wordlist update, and the branch was rebased to resolve conflicts before merging.
74%
#5157 Honor the ${pcfiledir} entries in pkgconfig snapcraft merged Merged following two approvals and passing CI. The change updates the craft-parts dependency and implements logic to honor ${pcfiledir} entries in pkgconfig, ensuring .pc files remain relocatable. Resolves #5158.
72%