← Back to issue list

Also use INSTALLROOT for make plugin.

View original Github issue

Metadata

Project
snapcraft
Number
#697
Type
pull request
State
closed
Author
jhobbs
Labels
—
Created
Updated
Closed

Current evaluation

PR proposing appending INSTALLROOT to make installs was closed unmerged by maintainer sergiusens in favour of #711, which added a configurable make-install-var to the Make plugin and merged as commit 542ae9649.

Resolution: closed superseded

Reason: On 2016-08-04 sergiusens closed #697 explicitly 'in favor of #711 which will handle more cases'. #711 (Add make-install-var field to the make plugin) was merged as commit 542ae9649, delivering a broader configurable solution instead of the hardcoded INSTALLROOT append.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Some projects don't use DESTDIR - it's only a gnu convention. make will ignore arguments that aren't used, so appending is cleaner than exposing a new option on the command line, and just works.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR proposing appending INSTALLROOT to make installs was closed unmerged by maintainer sergiusens in favour of #711, which added a configurable make-install-var to the Make plugin and merged as commit 542ae9649.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of snapcraft#711, which was subsequently merged to provide a broader, configurable make-install-var solution for the Make plugin.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of canonical/snapcraft#711, which added a broader make-install-var solution for customizing Makefile installation paths.
qwen/qwen3.6-35b-a3b — — Superseded by PR #711, which implements a broader solution for make plugin installation paths. The proposal to append INSTALLROOT was closed to consolidate changes and address additional use cases.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded by pull request #711, which implements a broader solution. The INSTALLROOT change for the make plugin was incorporated into that larger fix.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#711 (confidence 97%)

    Maintainer comment on #697 names #711 as the replacement; merged as commit 542ae9649 adding make-install-var to the Make plugin.

  • Related To: canonical/snapcraft#711 (confidence 80%)

    sergiusens linked Launchpad bug 1609116 as the broader design discussion that #711 implements.

Related issues

Issue Project State Summary Similarity
#711 Add make-install-var field to the make plugin. snapcraft merged Merged PR #711 added make-install-var to the Make plugin, allowing projects to customize the Makefile install flag; merged as commit 542ae9649.
72%