Clarification of make plugin help text
Metadata
Current evaluation
Merged as commit 7b0f5befc, clarifying that the make plugin runs the default target followed by make install.
Resolution: closed resolved
Reason: PR #730 was merged into Snapcraft as commit 7b0f5befc. Its updated help text explains the default build target and additional install step.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Just helped debug a makefile based project that failed because 'install' was the default target, and running 'make && make install' broke the build. This clarification would've made it easier to understand what the plugin was actually doing.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 7b0f5befc, clarifying that the make plugin runs the default target followed by make install. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 7b0f5befc, clarifying the make plugin help text about the default target and the extra make install step. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #730 (commit 7b0f5befc) to clarify the make plugin’s help text, explaining its implicit make and make install steps and incorporating feedback from #715. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #730 via commit 7b0f5befc, clarifying the make plugin help text about running make install and the risk when install is the default target. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged clarification to the make plugin help text to prevent build failures when 'install' is the default target. Reviewers approved the update after referencing PR #715, and the change was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged following maintainer review and approval. Updated the make plugin help text to clarify default target behavior and prevent build failures from sequential make commands. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#715
(confidence 95%)
The reviewer requested incorporating #715, which added artifact handling and allowed skipping make install when artifacts were specified.
Related issues
No related issues found above the similarity threshold.