← Back to issue list

Use a recursive iglob for filesets

View original Github issue

Metadata

Project
snapcraft
Number
#765
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #765 via commit 2d7fc117b, adding recursive ** globbing for part filesets; an unintended .pth-filtering regression was later fixed in #822 for 2.18.1.

Resolution: closed resolved

Reason: PR #765 was merged as commit 2d7fc117b, implementing recursive fileset expansion. Its acknowledged .pth regression was addressed separately by PR #822 via commit 66d6f7827.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This adds support for `**` in filesets for parts. LP: #1616464 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #765 via commit 2d7fc117b, adding recursive ** globbing for part filesets; an unintended .pth-filtering regression was later fixed in #822 for 2.18.1.
stealth/space-bunny-alpha — closed resolved Merged #765 via 2d7fc117b, adding recursive ** support to part filesets; follow-up #822 restored Python .pth files omitted by the change for 2.18.1.
stealth/space-bunny-alpha — closed resolved PR #765 by sergiusens was merged (commit 2d7fc117b), adding recursive iglob support so `**` works in part filesets (LP #1616464). Unintended .pth filtering it introduced was later fixed by #822 for 2.18.1.
stealth/space-bunny-alpha — closed resolved Merged as commit 2d7fc117b (#765), adding recursive iglob so `**` works in part filesets (LP #1616464). It also filtered .pth files, a regression fixed separately by #822 for 2.18.1.
stealth/space-bunny-alpha — closed resolved PR #765 merged as commit 2d7fc117b, switching part fileset globbing to a recursive iglob so `**` patterns work (LP #1616464). The .pth filtering regression it exposed was later fixed by #822.
stealth/space-bunny-alpha — closed resolved Merged as 2d7fc117b: part filesets now use recursive iglob, adding ** support (LP #1616464). Side effect of dropping .pth filtering was later reverted in #822 for 2.18.1.
stealth/space-bunny-alpha — closed resolved Merged in #765 via 2d7fc117b, adding recursive iglob support for ** in part filesets. Unintended .pth filtering was acknowledged as an oversight and addressed separately for 2.18.1.
qwen/qwen3.6-35b-a3b — — Merged to add recursive iglob support for filesets. The change inadvertently caused .pth file removal issues for some Python packages. The maintainer acknowledged the oversight and prepared a follow-up fix for version 2.18.1.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable recursive glob patterns in filesets. A post-merge bug where .pth file removal broke Python imports was identified. Maintainers acknowledged the oversight and prepared a corrective patch for release 2.18.1.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#822 (confidence 99%)

    Restored Python .pth files removed by this change and was prepared for release 2.18.1.

Related issues

No related issues found above the similarity threshold.