Some plugins fixes
Metadata
Current evaluation
Combined 3-change PR by ehbello (dump/copy cross-compilation, git --single-branch, dropping --depth=1) was split at maintainer request; closed unmerged. Cross-compilation part landed as #791 (commit 97742500a).
Resolution: closed superseded
Reason: Maintainer come-maiz asked on 2016-09-10 to split the changes into separate PRs; the author replied 'Done' and #789 was closed unmerged. The dump/copy plugin cross-compilation change landed as canonical/snapcraft#791 in commit 97742500a; the git clone changes (--single-branch, removing --depth=1) were dropped/never landed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This pull merge has three important modifications:
a) Enable crosscompilation for dump and copy plugins to be able to use them, for example, providing blobs after build a kernel snap for a different architecture.
b) Speed up the pull time of a git repository only downloading the commits of related branch thanks to `--single-branch` switch of Git.
c) Remove `--depth=1` of HTTP transport for Git due there are repositories as git.kernel.org that does not support that.
I would be happy to see these changes in the next version of Snapcraft.
Regards.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Combined 3-change PR by ehbello (dump/copy cross-compilation, git --single-branch, dropping --depth=1) was split at maintainer request; closed unmerged. Cross-compilation part landed as #791 (commit 97742500a). | |
| stealth/space-bunny-alpha | — | closed superseded | Split into separate PRs; the dump/copy cross-compilation change landed as #791 in commit 97742500a. The combined PR was closed without merging. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. Maintainers requested splitting the three plugin fixes into separate pull requests and signing the contributor agreement. The author agreed to comply, but the original PR was not merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed and superseded by separate PRs after the author agreed to split the three plugin fixes into individual pull requests and sign the contributor agreement. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#791
(confidence 92%)
Split-out PR for part (a), merged as commit 97742500a 'Enable crosscompilation for dump and copy plugins (#791)'
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #791 Enable crosscompilation for dump and copy plugins | snapcraft | merged | External contribution by ehbello merged as commit 97742500a (LP: #1624544), adding crosscompilation support to the dump and copy plugins so they can provide foreign-architecture blobs, e.g. after cross-building a kernel snap. | |
| #1253 go plugin: cross-compilation support | snapcraft | closed | Closed unmerged after the author split it into #1338 (cross-compilation), #1343 (CGo cross-compile), #1346 (multi-arch build deps) and #1348 (foreign arch setup). #1338 (a167ec4a3) and #1343 (55fe00c67) were merged. |