← Back to issue list

Do not run the bootstrap directory as a script (autotools plugin).

View original Github issue

Metadata

Project
snapcraft
Number
#803
Type
pull request
State
merged
Author
evandandrea
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #803 (commit eee1b84dd,2016-09-15) fixed the autotools plugin so a 'bootstrap' directory in the source is not executed as a script, e.g. for Basho's OTP fork used by Riak.

Resolution: closed resolved

Reason: PR #803 was approved by sergiusens ('ok to test') and merged to master as commit eee1b84dd, 'autotools plugin: Do not run the bootstrap directory as a script. (#803)', adding the check in snapcraft's autotools plugin.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Sometimes an autotools-using project has a bootstrap directory, such as Basho's fork of Erlang (https://github.com/basho/otp) as used in Riak.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #803 (commit eee1b84dd,2016-09-15) fixed the autotools plugin so a 'bootstrap' directory in the source is not executed as a script, e.g. for Basho's OTP fork used by Riak.
stealth/space-bunny-alpha — closed resolved Merged PR #803 (commit eee1b84dd) fixed autotools bootstrap detection so bootstrap directories are not executed as scripts.
qwen/qwen3.6-35b-a3b — — Merged to prevent the autotools plugin from executing the bootstrap directory as a script. Approved by sergiusens, the two-file change ensures correct handling of projects like Basho's Erlang fork that include a bootstrap directory.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated the autotools plugin to exclude the bootstrap directory from script execution, resolving build failures for projects like Basho's Erlang fork. Approved by @sergiusens.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3398 (confidence 55%)

    Later PR adding autogen.sh/bootstrap support to the autotools v2 plugin, extending the same bootstrap handling this PR guarded.

  • Related To: canonical/craft-parts#533 (confidence 45%)

    Later craft-parts commit 45cbc684 'autotools plugin: support bootstrap parameters', a successor feature to this bootstrap fix.

Related issues

No related issues found above the similarity threshold.