← Back to issue list

Adjust login to conform to UX specification

View original Github issue

Metadata

Project
snapcraft
Number
#804
Type
pull request
State
merged
Author
cjwatson
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #804 (commit bee0b41ba): snapcraft login now prompts for 2FA only when the store returns the 'two-factor required' error, and prints a hint (hardcoded SSO FAQ link) after a successful login without 2FA. LP: #1621710.

Resolution: closed resolved

Reason: The pull request itself was merged into snapcraft (commit bee0b41ba, +132/-58 across 9 files) after approval by a maintainer, implementing the UX specification for login: 2FA is only requested when the store signals it is required, with an SSO FAQ hint otherwise.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The store now returns an unambiguous error to indicate that two-factor authentication is required, so we can use that to make the login process behave how the UX specification says it should: only prompt for 2fa if necessary, and provide a hint on a successful login without 2fa. One obvious hack in this change is that we don't yet provide a convenient per-store link for enabling 2fa, but instead just hardcode a link to the SSO FAQ for now. At the moment, people have to explicitly opt into 2fa by joining a Launchpad team, which is a deliberate decision because we don't have a good recovery facility and can't afford the support bandwidth of doing manual recovery for millions of users. When this changes then we can also update snapcraft to do something more graceful here, but for the moment I think this is tolerable. LP: #1621710

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #804 (commit bee0b41ba): snapcraft login now prompts for 2FA only when the store returns the 'two-factor required' error, and prints a hint (hardcoded SSO FAQ link) after a successful login without 2FA. LP: #1621710.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#804 (commit bee0b41ba), updating login to request 2FA only when required and show guidance when a successful login skips it.
stealth/space-bunny-alpha — closed resolved Merged #804 (bee0b41ba), aligning login with the UX spec by prompting for 2FA only when required and adding a hint after logins without 2FA.
qwen/qwen3.6-35b-a3b — — Merged. Updates login flow to match UX specs by conditionally prompting for 2FA and adding success hints. Temporarily hardcodes SSO FAQ link for enabling 2FA. Approved by one reviewer, changed nine files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated login flow to prompt for two-factor authentication only when required, aligning with UX specifications. Temporarily hardcodes an SSO FAQ link for 2FA enrollment until native options exist. Resolves LP: #1621710.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1621710 snapcraft login does not match the UX spec snapcraft (launchpad) closed Fixed by merged snapcore/snapcraft PR #804 (commit bee0b41ba), aligning snapcraft login with the UX spec, including conditional 2FA and MFA guidance.
78%
#1635567 On snapcraft login, we are recommending to use 2fa, but that's not a public feature snapcraft (launchpad) closed The 2FA recommendation was intentionally retained pending public Store support; removal PR snapcore/snapcraft#1066 was closed unmerged.
72%