Don't follow symlinks when provisioning the build
Metadata
Current evaluation
Merged PR #83 (branch local_source_copy_fix) via merge commit 7071da3ea, change commit 503e9b2b7, stopping source copy from following symlinks during build provisioning and fixing the local-source build failure.
Resolution: closed resolved
Reason: The PR was merged into trunk as commit 7071da3ea (change commit 503e9b2b7) after come-maiz confirmed on2015-11-06 that the branch fixed the reported 'package.xml'/find failure in examples/ros and gave a +1. The fix stops symlink following when copying local sources into the part build directory.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #83 (branch local_source_copy_fix) via merge commit 7071da3ea, change commit 503e9b2b7, stopping source copy from following symlinks during build provisioning and fixing the local-source build failure. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#83 via commit 503e9b2b7, preventing symlink following during build provisioning and fixing the reported build error. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to prevent symlink following during build provisioning, resolving a build error. Tested and approved by a reviewer before integration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Prevents following symlinks during build provisioning, resolving a find command failure caused by missing directories. Verified and approved by come-maiz. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#478
(confidence 55%)
Later change 'Follow symlinks while hard-linking migrated files' touches the same local source handling area.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1659653 Symlinks to directories in local sources aren't pulled as symlinks | snapcraft (launchpad) | closed | Merged PR #1081 (commit baeec1045) fixed local source handling to preserve directory symlinks instead of replacing them with directories. | |
| #377 Correct local source pulling | snapcraft | merged | Merged PR #377 corrected symlink-aware local source checks, preventing cleanup failures and allowing local sources to be pulled twice without an "is a symlink" error. |