Replace SNAPCRAFT_PART_INSTALL in the part attributes.
Metadata
Current evaluation
Merged after dual reviewer approval. Replaced SNAPCRAFT_PART_INSTALL references across seven files with a 70-line update. Reviewers suggested adding cmake integration tests, but the change was merged without them.
Suggested action: —
No scores available.
Issue body
LP:#1628915
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after dual reviewer approval. Replaced SNAPCRAFT_PART_INSTALL references across seven files with a 70-line update. Reviewers suggested adding cmake integration tests, but the change was merged without them. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after reviewer approval. The change replaces SNAPCRAFT_PART_INSTALL in part attributes. Reviewers requested integration tests, but the contribution was merged following positive feedback and confirmation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged an external contribution replacing SNAPCRAFT_PART_INSTALL in part attributes. Reviewers requested cmake integration tests, which were added before final approval and merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3414 project loader: export SNAPCRAFT_TARGET_ARCH in build environment | snapcraft | merged | Exported SNAPCRAFT_TARGET_ARCH in the build environment. Merged after single reviewer approval, modifying two files with six additions and two deletions. | |
| #2122 many: introduce variables for part src and build | snapcraft | merged | Merged following approval. Introduces new environment variables and replacements for part src and build directories, resolving LP #1763028. Consolidates SNAPCRAFT_* environment handling into a single location. Approved by one reviewer with passing CI checks. | |
| #73 tests: add stage snaps integration test (CRAFT-68) | craft-parts | merged | Merged an integration test verifying stage-snaps are correctly unpacked into the part install directory. Approved by two reviewers, passed CI, and added 133 lines across two files. | |
| #3636 parts: integrate craft-parts (CRAFT-765) | snapcraft | merged | Merged after reviewer approval and passing CI checks. Integrates craft-parts for part validation and lifecycle processing. Modifies 12 files, adding 369 lines and removing 20, fulfilling CRAFT-765. | |
| #3154 cmake v2 plugin: take source-subdir into account | snapcraft | merged | Merged. Updates cmake v2 plugin to use SNAPCRAFT_PART_SOURCE_WORK instead of SNAPCRAFT_PART_SOURCE for pull and build steps, fixing source subdirectory handling. Approved, passed CI, and modified 10 files (+55/-7). | |
| #3123 cmake v2 plugin: configure with $SNAPCRAFT_PART_SRC | snapcraft | merged | Merged a fix updating the cmake v2 plugin to configure via $SNAPCRAFT_PART_SRC. This resolves build failures for projects verifying distinct source and build directories. Approved by one reviewer and passed CI checks. | |
| #1628915 SNAPCRAFT_PART_INSTALL is not being replaced when called by the build tools | snapcraft (launchpad) | closed | Closed without a documented fix. The report detailed SNAPCRAFT_PART_INSTALL expansion failing in build tools, causing nested install paths. With zero comments and no follow-up, the issue was likely abandoned or superseded by subsequent project changes. | |
| #184 plugins: cmake | craft-parts | merged | Merged the cmake plugin port to craft-parts following approval from two reviewers and passing CI checks. The maintainer addressed review feedback regarding leftover code prior to integration. | |
| #3340 include SNAPCRAFT_STAGE in XDG_DATA_DIRS, needed to find Gir files built by other parts | snapcraft | merged | Merged a two-line change adding SNAPCRAFT_STAGE to XDG_DATA_DIRS, enabling cross-part discovery of built Gir files. Approved by one reviewer and passed all CI checks. | |
| #1334 refactor(parts): move craft-parts related things into their own package | charmcraft | merged | Merged a refactor that moves craft-parts components into a dedicated package. Approved by two reviewers with zero unresolved comments. The change modifies 16 files, adding 960 lines and removing 794. |