← Back to issue list

Replace SNAPCRAFT_PART_INSTALL in the part attributes.

View original Github issue

Metadata

Project
snapcraft
Number
#841
Type
pull request
State
merged
Author
josepht
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 6cef6c0f9 via canonical/snapcraft#841, replacing SNAPCRAFT_PART_INSTALL in part attributes with the part-specific install path.

Resolution: closed resolved

Reason: The approved pull request was merged into Snapcraft as commit 6cef6c0f9, completing the replacement for LP#1628915.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP:#1628915

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 6cef6c0f9 via canonical/snapcraft#841, replacing SNAPCRAFT_PART_INSTALL in part attributes with the part-specific install path.
stealth/space-bunny-alpha — closed resolved Merged PR #841 as commit 6cef6c0f9, expanding SNAPCRAFT_PART_INSTALL in part attributes so build tools receive the correct install path.
stealth/space-bunny-alpha — closed resolved Merged as commit 6cef6c0f9 via canonical/snapcraft#841, replacing SNAPCRAFT_PART_INSTALL in part attributes to fix build-tool install-path expansion (LP#1628915).
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#841 (commit 6cef6c0f9), replacing SNAPCRAFT_PART_INSTALL in part attributes across seven files. Requested cmake integration tests were not added.
qwen/qwen3.6-35b-a3b — — Merged after dual reviewer approval. Replaced SNAPCRAFT_PART_INSTALL references across seven files with a 70-line update. Reviewers suggested adding cmake integration tests, but the change was merged without them.
qwen3.6-35b-a3b-mtp-q6 — — Merged after reviewer approval. The change replaces SNAPCRAFT_PART_INSTALL in part attributes. Reviewers requested integration tests, but the contribution was merged following positive feedback and confirmation.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#757 (confidence 90%)

    Earlier merged PR dc0b68174 exported the per-part SNAPCRAFT_PART_INSTALL variable used by these attributes.

Related issues

Issue Project State Summary Similarity
#1822375 SNAPCRAFT_PART_INSTALL doesn't expand in build-environment assignments snapcraft (launchpad) closed Fixed in PR #841 (commit 6cef6c0f9) by replacing SNAPCRAFT_PART_INSTALL in part attributes with the part-specific install path.
86%
#1628915 SNAPCRAFT_PART_INSTALL is not being replaced when called by the build tools snapcraft (launchpad) closed SNAPCRAFT_PART_INSTALL expansion in part attributes was fixed by merged canonical/snapcraft PR #841 in commit 6cef6c0f9, resolving the malformed nested install paths.
86%
#1719951 SNAPCRAFT_PARTS_URI doesn't work with cleanbuild snapcraft (launchpad) closed Fixed cleanbuild remote-part resolution by forwarding SNAPCRAFT_PARTS_URI into LXD; merged in snapcore/snapcraft#1585 (13ea598d5).
72%
#1719928 snapcraft update won't fetch from SNAPCRAFT_PARTS_URI snapcraft (launchpad) closed Fixed by snapcore/snapcraft PR #1856, which keyed cached parts data by SNAPCRAFT_PARTS_URI so alternate part sources were no longer treated as already current.
72%
#1816 snapcraft update won't fetch from `SNAPCRAFT_PARTS_URI` snapcraft closed Superseded by Launchpad #1719928 and fixed by merged PR #1856 (commit 5a0a8c075), adding URI-specific remote-parts cache folders to prevent stale metadata collisions.
71%
#1585 lxd: pass SNAPCRAFT_PARTS_URI through into container snapcraft merged Merged in canonical/snapcraft#1585 (13ea598d5), forwarding SNAPCRAFT_PARTS_URI into LXD containers so cleanbuild can resolve remote parts; fixes Launchpad #1719951.
70%