← Back to issue list

create the deltas package/class with xdetal generation implementation

View original Github issue

Metadata

Project
snapcraft
Number
#918
Type
pull request
State
merged
Author
seawaywen
Labels
—
Created
Updated
Closed

Current evaluation

Merged the deltas package with XDelta-based source-to-target delta generation; the implementation landed in commit a129cdfee.

Resolution: closed resolved

Reason: PR #918 was approved and merged as commit a129cdfee. It added XDelta delta generation, executable validation, temporary logging, and test-specific cleanup.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add a new package "deltas" and implement the XDelta based delta generation feature. By specifying the source file and target file, it can generate the delta file base on xdelta algorithm. (Flexible to extend to use the other algorithms like *bsdiff* later) LP: #1642822

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged the deltas package with XDelta-based source-to-target delta generation; the implementation landed in commit a129cdfee.
stealth/space-bunny-alpha — closed resolved Merged #918, adding the deltas package and XDelta-based generation implementation; landed as a129cdfee after review cleanup.
stealth/space-bunny-alpha — closed resolved Merged #918, adding the deltas package and XDelta-based delta generation. Changes landed as a129cdfee after reviewer-requested parameter, logging, and test cleanup.
qwen/qwen3.6-35b-a3b — — Merged the deltas package implementing XDelta-based delta generation. Incorporated reviewer feedback to refactor class attributes, add /tmp logging, and include test cleanup parameters. Approved and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged a PR adding a deltas package for XDelta-based delta generation. Feedback was incorporated by moving attributes to init, improving path detection, adding temporary error logging, and introducing a test flag for log cleanup.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#934 (confidence 95%)

    Follow-up PR #934 migrated the implementation from xdelta to xdelta3 in commit f4abf6f4b.

Related issues

Issue Project State Summary Similarity
#1642822 Generate the delta file in snapcraft by introducing the new deltas package snapcraft (launchpad) closed XDelta-based delta generation landed as the new snapcraft 'deltas' package, merged in canonical/snapcraft#918 (commit a129cdfee), with follow-ups adding delta uploads to push (#940) and xdelta3 migration (#934).
73%