← Back to issue list

pluginhandler: ensure staged files are included in the prime step.

View original Github issue

Metadata

Project
snapcraft
Number
#920
Type
pull request
State
merged
Author
josepht
Labels
Created
Updated
Closed

Current evaluation

Merged into master. Resolves Launchpad bugs #1623279 and #1605164 by ensuring the prime step correctly includes staged files when using wildcards or exclusions. Approved, passed CI, and includes new tests.

Suggested action:

No scores available.

Issue body

If the 'prime' fileset is made up of '*/' or only includes '-XXX' entries combine the 'stage' fileset as well. LP:#1623279 LP:#1605164

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into master. Resolves Launchpad bugs #1623279 and #1605164 by ensuring the prime step correctly includes staged files when using wildcards or exclusions. Approved, passed CI, and includes new tests.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Resolves LP:#1623279 and LP:#1605164 by ensuring the prime fileset combines with the stage fileset when wildcards or exclusions are present. Passed code review and CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Fixes pluginhandler to combine the stage fileset with prime when wildcards or exclusions are used, ensuring staged files are included. Approved after code review, rebasing, and passing CI checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1059 pluginhandler: support more complex stage-packages. snapcraft merged Merged. Adds a complex grammar for stage-packages using on and try/else clauses to filter packages by selectors like target architecture, resolving LP #1637282. Approved by reviewer and passed CI.
70%