← Back to issue list

pluginhandler: ensure staged files are included in the prime step.

View original Github issue

Metadata

Project
snapcraft
Number
#920
Type
pull request
State
merged
Author
josepht
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #920 as commit 5a253c13a, including staged files in prime when prime uses wildcards or only exclusions and fixing missing staged artifacts.

Resolution: closed resolved

Reason: PR #920 was approved and merged as commit 5a253c13a. The change combines stage and prime filesets for wildcard or exclusion-only prime entries, addressing LP#1623279 and LP#1605164.

Evaluated by: mr-cal-bot

No scores available.

Issue body

If the 'prime' fileset is made up of '*/' or only includes '-XXX' entries combine the 'stage' fileset as well. LP:#1623279 LP:#1605164

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #920 as commit 5a253c13a, including staged files in prime when prime uses wildcards or only exclusions and fixing missing staged artifacts.
stealth/space-bunny-alpha — closed resolved Merged PR #920 as commit 5a253c13a, ensuring staged files are included when prime uses wildcards or exclusions; addresses LP#1623279 and LP#1605164.
qwen/qwen3.6-35b-a3b — — Merged into master. Resolves Launchpad bugs #1623279 and #1605164 by ensuring the prime step correctly includes staged files when using wildcards or exclusions. Approved, passed CI, and includes new tests.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Resolves LP:#1623279 and LP:#1605164 by ensuring the prime fileset combines with the stage fileset when wildcards or exclusions are present. Passed code review and CI checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2450 pluginhandler: handle removal of inconsistent files snapcraft merged Merged PR #2450 in commit 9fdd3bdc7, making cleanup tolerate manually removed stage/prime files and warn instead of failing.
76%
#1605164 Errors due to "missing" files using "stage:" snapcraft (launchpad) closed Report of "missing" file errors from excluding paths via a stage: stanza was fixed by merged PR snapcore/snapcraft#920 (commit 5a253c13a), which made pluginhandler include staged files during prime for excludes/wildcard-only entries.
72%
#2047 pluginhandler: organize in build instead of stage snapcraft merged Merged PR #2047 moved organize handling from stage to build, fixing repeat staging and ensuring collision detection sees organized files.
71%