sources: add current dir to ignore list if we're iterating on parent
Metadata
Current evaluation
Merged as 0061361e8: parent-directory source traversal now ignores SNAPCRAFT_FILES in the current directory, preventing repeated traversal; integration tests were added.
Resolution: closed resolved
Reason: PR #926 was merged into master as commit 0061361e8. It fixes local parent-source traversal and adds integration coverage while rewriting the relevant unit tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This avoids to iterate over and over our ignored folders when launching snapcraft from a sub-sub-folder of the sources.
Added integration tests. Rewritten unit tests.
Fixes <a href='http://pad.lv/1644350'>LP: #1644350</a>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 0061361e8: parent-directory source traversal now ignores SNAPCRAFT_FILES in the current directory, preventing repeated traversal; integration tests were added. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #926 merged to master as 0061361e8: Local source now adds the current dir to the ignore list when pulling from a parent, avoiding repeated traversal of ignored dirs. Fixes LP: #1644350; integration tests added, unit tests rewritten. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #926 merged as commit 0061361e8 (sources: add current dir to ignore list if we're iterating on parent), fixing LP: #1644350; Local source now ignores SNAPCRAFT_FILES in the cwd when pulling from a parent dir. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into master in #926 (0061361e8): parent-source traversal now ignores the current directory, avoiding repeated traversal of ignored folders. Integration tests were added and unit tests rewritten. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Prevents redundant folder iteration when running snapcraft from subdirectories by adding the current directory to the ignore list. Includes updated tests, resolves LP: #1644350, and passed review and CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Adds the current directory to the ignore list when iterating over a parent, preventing redundant folder scanning. Resolves LP: #1644350. Includes updated tests and maintains code coverage. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
launchpad#1644350
(confidence 95%)
The PR explicitly states that it fixes Launchpad bug #1644350.
Related issues
No related issues found above the similarity threshold.